<div dir="ltr">any progress on this, or interest?<div><br></div><div>Cheers,</div><div>Rene</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Feb 4, 2021 at 9:01 AM Rene Peinthor <<a href="mailto:rene.peinthor@linbit.com">rene.peinthor@linbit.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I didn't get any feedback on V2, nor any updates if you still reviewing,<br>
but I found myself a few issues.<br>
<br>
First in V2 the <source/host> element wasn't optional<br>
(which it should be) and I improved a few error messages,<br>
because sometimes it wasn't clear from where the error<br>
originated.<br>
<br>
Best regards,<br>
Rene<br>
<br>
Rene Peinthor (3):<br>
storage: Linstor configuration<br>
storage: Linstor support<br>
storage: Add tests for the Linstor storage backend<br>
<br>
docs/schemas/storagepool.rng | 27 +<br>
docs/<a href="http://storage.html.in" rel="noreferrer" target="_blank">storage.html.in</a> | 39 +<br>
include/libvirt/libvirt-storage.h | 1 +<br>
meson.build | 6 +<br>
meson_options.txt | 1 +<br>
po/POTFILES.in | 1 +<br>
src/conf/domain_conf.c | 1 +<br>
src/conf/storage_conf.c | 13 +-<br>
src/conf/storage_conf.h | 1 +<br>
src/conf/virstorageobj.c | 4 +-<br>
src/storage/meson.build | 25 +<br>
src/storage/storage_backend.c | 6 +<br>
src/storage/storage_backend_linstor.c | 783 ++++++++++++++++++<br>
src/storage/storage_backend_linstor.h | 24 +<br>
src/storage/storage_backend_linstor_priv.h | 53 ++<br>
src/storage/storage_driver.c | 1 +<br>
src/test/test_driver.c | 1 +<br>
tests/linstorjsondata/broken.json | 1 +<br>
tests/linstorjsondata/resource-group.json | 1 +<br>
.../linstorjsondata/resource-list-test2.json | 332 ++++++++<br>
.../storage-pools-ssdpool.json | 72 ++<br>
tests/linstorjsondata/storage-pools.json | 192 +++++<br>
tests/linstorjsondata/volume-def-list.json | 158 ++++<br>
.../volume-definition-test2.json | 1 +<br>
tests/meson.build | 6 +<br>
tests/storagebackendlinstortest.c | 372 +++++++++<br>
.../storagepoolcapsschemadata/poolcaps-fs.xml | 7 +<br>
.../poolcaps-full.xml | 7 +<br>
tests/storagepoolxml2argvtest.c | 1 +<br>
tests/storagepoolxml2xmlin/pool-linstor.xml | 8 +<br>
tests/storagevolxml2xmlin/vol-linstor.xml | 10 +<br>
tools/virsh-pool.c | 3 +<br>
32 files changed, 2156 insertions(+), 2 deletions(-)<br>
create mode 100644 src/storage/storage_backend_linstor.c<br>
create mode 100644 src/storage/storage_backend_linstor.h<br>
create mode 100644 src/storage/storage_backend_linstor_priv.h<br>
create mode 100644 tests/linstorjsondata/broken.json<br>
create mode 100644 tests/linstorjsondata/resource-group.json<br>
create mode 100644 tests/linstorjsondata/resource-list-test2.json<br>
create mode 100644 tests/linstorjsondata/storage-pools-ssdpool.json<br>
create mode 100644 tests/linstorjsondata/storage-pools.json<br>
create mode 100644 tests/linstorjsondata/volume-def-list.json<br>
create mode 100644 tests/linstorjsondata/volume-definition-test2.json<br>
create mode 100644 tests/storagebackendlinstortest.c<br>
create mode 100644 tests/storagepoolxml2xmlin/pool-linstor.xml<br>
create mode 100644 tests/storagevolxml2xmlin/vol-linstor.xml<br>
<br>
-- <br>
2.30.0<br>
<br>
</blockquote></div>