<div dir="ltr"><div dir="ltr"><div><br> </div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Apr 22, 2021 at 4:50 PM “Meina <<a href="mailto:meili@redhat.com">meili@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Update slice xml from block lun disk because it doesn't support storage slice<br>
<br></blockquote><div><div>Better if mentioning the bug or the commit of forbidding slice element with lun device</div><div><a href="https://bugzilla.redhat.com/show_bug.cgi?id=1820040">https://bugzilla.redhat.com/show_bug.cgi?id=1820040</a></div><div>5d72c3ce28 qemu: domain: Forbid slice/encryption/copy_on_read with disk type='lun'</div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Signed-off-by: Meina Li <<a href="mailto:meili@redhat.com" target="_blank">meili@redhat.com</a>><br>
---<br>
 docs/formatdomain.rst | 11 ++++++-----<br>
 1 file changed, 6 insertions(+), 5 deletions(-)<br>
<br>
diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst<br>
index 1b9b221611..44aee9fa77 100644<br>
--- a/docs/formatdomain.rst<br>
+++ b/docs/formatdomain.rst<br>
@@ -2381,9 +2381,6 @@ paravirtualized driver is specified via the ``disk`` element.<br>
      <disk type='block' device='lun'><br>
        <driver name='qemu' type='raw'/><br>
        <source dev='/dev/sda'><br>
-         <slices><br>
-           <slice type='storage' offset='12345' size='123'/><br>
-         </slices><br>
          <reservations managed='no'><br>
            <source type='unix' path='/path/to/qemu-pr-helper' mode='client'/><br>
          </reservations><br>
@@ -2393,10 +2390,14 @@ paravirtualized driver is specified via the ``disk`` element.<br>
      </disk><br>
      <disk type='block' device='disk'><br>
        <driver name='qemu' type='raw'/><br>
-       <source dev='/dev/sda'/><br>
+       <source dev='/dev/sda'><br>
+         <slices><br>
+           <slice type='storage' offset='12345' size='123'/><br>
+         </slices><br>
+       </source><br>
        <geometry cyls='16383' heads='16' secs='63' trans='lba'/><br>
        <blockio logical_block_size='512' physical_block_size='4096'/><br>
-       <target dev='hdj' bus='ide'/><br>
+       <target dev='sda' bus='scsi'/><br>
      </disk><br>
      <disk type='volume' device='disk'><br>
        <driver name='qemu' type='raw'/><br>
-- <br>
2.27.0<br>
<br>
</blockquote></div></div>