<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Apr 19, 2021 at 8:56 PM Michal Privoznik <<a href="mailto:mprivozn@redhat.com">mprivozn@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 3/30/21 8:36 AM, Han Han wrote:<br>
> <br>
> Han Han (3):<br>
> tests: negative test for hugepages with anonymous memory backing<br>
> tests: negative test for hugepages with ondemand mode<br>
> tests: negative test of binding memnode cellid to an nonexist guest<br>
> cell<br>
> <br>
> .../qemuxml2argvdata/hugepages-anonymous.err | 1 +<br>
> .../qemuxml2argvdata/hugepages-anonymous.xml | 25 +++++++++++++++<br>
> tests/qemuxml2argvdata/hugepages-ondemand.err | 1 +<br>
> tests/qemuxml2argvdata/hugepages-ondemand.xml | 25 +++++++++++++++<br>
> ...une-memnode-cellid-nonexist-guest-cell.err | 1 +<br>
> ...une-memnode-cellid-nonexist-guest-cell.xml | 31 +++++++++++++++++++<br>
> tests/qemuxml2argvtest.c | 3 ++<br>
> 7 files changed, 87 insertions(+)<br>
> create mode 100644 tests/qemuxml2argvdata/hugepages-anonymous.err<br>
> create mode 100644 tests/qemuxml2argvdata/hugepages-anonymous.xml<br>
> create mode 100644 tests/qemuxml2argvdata/hugepages-ondemand.err<br>
> create mode 100644 tests/qemuxml2argvdata/hugepages-ondemand.xml<br>
> create mode 100644 tests/qemuxml2argvdata/numatune-memnode-cellid-nonexist-guest-cell.err<br>
> create mode 100644 tests/qemuxml2argvdata/numatune-memnode-cellid-nonexist-guest-cell.xml<br>
> <br>
<br>
Han,<br>
<br>
what's the story behind these? I'm not particularly fan of testing that <br>
something does not work. Did we have regression in this area lately?<br></blockquote><div>No regression lately. I only intended to cover some negative cases in unit tests. <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Michal<br>
<br>
</blockquote></div></div>