<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, May 13, 2021 at 7:23 PM Pavel Hrdina <<a href="mailto:phrdina@redhat.com">phrdina@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Pavel Hrdina (2):<br>
storage: add support for QCOW2 cluster_size option<br>
storage_file: add support to probe cluster_size from QCOW2 images<br>
<br>
docs/<a href="http://formatstorage.html.in" rel="noreferrer" target="_blank">formatstorage.html.in</a> | 6 ++<br>
docs/schemas/storagecommon.rng | 7 +++<br>
docs/schemas/storagevol.rng | 3 +<br>
src/conf/storage_conf.c | 12 ++++<br>
src/storage/storage_util.c | 8 +++<br>
src/storage_file/storage_file_probe.c | 55 +++++++++++++------<br>
.../qcow2-clusterSize.argv | 6 ++<br>
tests/storagevolxml2argvtest.c | 4 ++<br>
.../vol-qcow2-clusterSize.xml | 17 ++++++<br>
.../vol-qcow2-clusterSize.xml | 17 ++++++<br>
tests/storagevolxml2xmltest.c | 1 +<br>
11 files changed, 120 insertions(+), 16 deletions(-)<br>
create mode 100644 tests/storagevolxml2argvdata/qcow2-clusterSize.argv<br>
create mode 100644 tests/storagevolxml2xmlin/vol-qcow2-clusterSize.xml<br>
create mode 100644 tests/storagevolxml2xmlout/vol-qcow2-clusterSize.xml<br>
<br></blockquote><div> Works for me when patched with libvirt v7.3.0-184-gdf28ba289c</div><div>➜ ~ cat /tmp/cluster.xml<br><volume type='file'><br> <name>cluster.qcow2</name><br> <key>/var/lib/libvirt/images/cluster.qcow2</key><br> <capacity unit='bytes'>5368709</capacity><br> <physical unit='bytes'>1271660544</physical><br> <target><br> <path>/var/lib/libvirt/images/hhan-pc.qcow2</path><br> <format type='qcow2'/><br> <permissions><br> <mode>0600</mode><br> <owner>0</owner><br> <group>0</group><br> <label>system_u:object_r:virt_image_t:s0</label><br> </permissions><br> <timestamps><br> <atime>1621221448.682657229</atime><br> <mtime>1618908525.055934734</mtime><br> <ctime>1618908525.253934734</ctime><br> <btime>0</btime><br> </timestamps><br> <compat>1.1</compat><br> <clusterSize>1024</clusterSize><br> <features><br> <lazy_refcounts/><br> </features><br> </target><br></volume><br><br>➜ ~ virt-xml-validate /tmp/cluster.xml<br>/tmp/cluster.xml validates</div><div><br></div><div>➜ ~ virsh vol-create images /tmp/cluster.xml<br>Vol cluster.qcow2 created from /tmp/cluster.xml<br><br>➜ ~ qemu-img info /var/lib/libvirt/images/cluster.qcow2 <br>image: /var/lib/libvirt/images/cluster.qcow2<br>file format: qcow2<br>virtual size: 5.12 MiB (5368832 bytes)<br>disk size: 4 KiB<br>cluster_size: 1024<br>Format specific information:<br> compat: 1.1<br> compression type: zlib<br> lazy refcounts: true<br> refcount bits: 16<br> corrupt: false<br> extended l2: false<br>➜ ~ virsh vol-dumpxml --pool images cluster.qcow2<br><volume type='file'><br> <name>cluster.qcow2</name><br> <key>/var/lib/libvirt/images/cluster.qcow2</key><br> <capacity unit='bytes'>5368832</capacity><br> <allocation unit='bytes'>4096</allocation><br> <physical unit='bytes'>3400</physical><br> <target><br> <path>/var/lib/libvirt/images/cluster.qcow2</path><br> <format type='qcow2'/><br> <permissions><br> <mode>0600</mode><br> <owner>0</owner><br> <group>0</group><br> <label>system_u:object_r:virt_image_t:s0</label><br> </permissions><br> <timestamps><br> <atime>1621224886.854657229</atime><br> <mtime>1621224875.045657229</mtime><br> <ctime>1621224875.049657229</ctime><br> <btime>0</btime><br> </timestamps><br> <compat>1.1</compat><br> <clusterSize unit='B'>1024</clusterSize><br> <features><br> <lazy_refcounts/><br> </features><br> </target><br></volume><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
-- <br>
2.31.1<br>
<br>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div>Reviewed-by: Han Han <<a href="mailto:hhan@redhat.com" target="_blank">hhan@redhat.com</a>></div><div>Tested-by: Han Han <<a href="mailto:hhan@redhat.com" target="_blank">hhan@redhat.com</a>></div></div></div></div>