<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Jun 11, 2021 at 4:55 PM Michal Prívozník <<a href="mailto:mprivozn@redhat.com">mprivozn@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 6/9/21 10:32 AM, Han Han wrote:<br>
> Diff from v1:<br>
> - Leave qemuBuildVirtioDevStr() unmodified<br>
> - New patch: qemu_validate: Validate virtio*gl* devices for 3d<br>
>   accerlation<br>
> - Use DO_TEST_CAPS_LATEST instead of DO_TEST<br>
> - Save video-virtio-vga-gpu-gl.x86_64-latest.xml as the sym link of tests/qemuxml2argvdata/video-virtio-vga-gpu-gl.xml<br>
> <br>
> v1: <a href="https://listman.redhat.com/archives/libvir-list/2021-June/msg00181.html" rel="noreferrer" target="_blank">https://listman.redhat.com/archives/libvir-list/2021-June/msg00181.html</a><br>
> <br>
> Han Han (6):<br>
>   qemu_capabilities: Add QEMU_CAPS_VIRTIO_GPU_GL_PCI<br>
>   qemu_capabilities: Add QEMU_CAPS_VIRTIO_VGA_GL<br>
>   qemu_validate: Validate virtio*gl* devices for 3d accerlation<br>
>   qemu: Adapt to virtio-gpu-gl-pci device<br>
>   qemu: Adapt to virtio-vga-gl device<br>
>   tests: Tests for virtio-vga-gl and virtio-gpu-gl-pci device<br>
> <br>
>  src/qemu/qemu_capabilities.c                  |  4 ++<br>
>  src/qemu/qemu_capabilities.h                  |  2 +<br>
>  src/qemu/qemu_command.c                       |  8 ++++<br>
>  src/qemu/qemu_validate.c                      |  4 +-<br>
>  .../caps_6.1.0.x86_64.xml                     |  2 +<br>
>  ...video-virtio-vga-gpu-gl.x86_64-latest.args | 35 ++++++++++++++<br>
>  .../video-virtio-vga-gpu-gl.xml               | 46 +++++++++++++++++++<br>
>  tests/qemuxml2argvtest.c                      |  1 +<br>
>  .../video-virtio-vga-gpu-gl.x86_64-latest.xml |  1 +<br>
>  tests/qemuxml2xmltest.c                       |  1 +<br>
>  10 files changed, 103 insertions(+), 1 deletion(-)<br>
>  create mode 100644 tests/qemuxml2argvdata/video-virtio-vga-gpu-gl.x86_64-latest.args<br>
>  create mode 100644 tests/qemuxml2argvdata/video-virtio-vga-gpu-gl.xml<br>
>  create mode 120000 tests/qemuxml2xmloutdata/video-virtio-vga-gpu-gl.x86_64-latest.xml<br>
> <br>
<br>
Patches look good. Please let me know if you agree with me squashing in<br>
suggested diffs.<br></blockquote><div>Only a trivial suggestion to your diffs. Others look good to me. <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Michal<br>
<br>
</blockquote></div></div>