<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Jun 11, 2021 at 4:55 PM Michal Prívozník <<a href="mailto:mprivozn@redhat.com">mprivozn@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 6/9/21 10:32 AM, Han Han wrote:<br>
> QEMU 6.1 will replace the virgl property of virtio-vga device to<br>
> virtio-vga-gl device. Adapt to that update.<br>
> <br>
> Resolves: <a href="https://gitlab.com/libvirt/libvirt/-/issues/167" rel="noreferrer" target="_blank">https://gitlab.com/libvirt/libvirt/-/issues/167</a><br>
> <br>
> Signed-off-by: Han Han <<a href="mailto:hhan@redhat.com" target="_blank">hhan@redhat.com</a>><br>
> ---<br>
> src/qemu/qemu_command.c | 3 +++<br>
> 1 file changed, 3 insertions(+)<br>
> <br>
> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c<br>
> index 6b9f13b219..56bc4b87eb 100644<br>
> --- a/src/qemu/qemu_command.c<br>
> +++ b/src/qemu/qemu_command.c<br>
> @@ -4239,6 +4239,9 @@ qemuBuildDeviceVideoStr(const virDomainDef *def,<br>
> }<br>
> } else {<br>
> virBufferAsprintf(&buf, "%s", model);<br>
> + if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_VIRTIO_VGA_GL) &&<br>
> + STREQ(model, "virtio-vga"))<br>
> + virBufferAddLit(&buf, "-gl");<br>
<br>
This enables -gl unconditionally, which is not desired. What we should<br>
do instead is:<br>
<br>
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c<br>
index c5275fe0ee..9f44c76d28 100644<br>
--- a/src/qemu/qemu_command.c<br>
+++ b/src/qemu/qemu_command.c<br>
@@ -4244,6 +4244,7 @@ qemuBuildDeviceVideoStr(const virDomainDef *def,<br>
} else {<br>
virBufferAsprintf(&buf, "%s", model);<br>
if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_VIRTIO_VGA_GL) &&<br>
+ accel3d == VIR_TRISTATE_SWITCH_ON &&<br></blockquote><div>Good catch. The condition for accel3d was missing in my code. </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
STREQ(model, "virtio-vga"))<br>
virBufferAddLit(&buf, "-gl");<br>
}<br>
<br>
<br>
Michal<br>
<br>
</blockquote></div></div>