<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jul 21, 2021 at 10:33 AM Kristina Hanicova <<a href="mailto:khanicov@redhat.com">khanicov@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I removed negation from the name of a variable to make the code<br>
more readable.<br>
<br>
Signed-off-by: Kristina Hanicova <<a href="mailto:khanicov@redhat.com" target="_blank">khanicov@redhat.com</a>><br>
---<br>
tests/lxcxml2xmltest.c | 12 ++++++------<br>
1 file changed, 6 insertions(+), 6 deletions(-)<br>
<br>
diff --git a/tests/lxcxml2xmltest.c b/tests/lxcxml2xmltest.c<br>
index 00341ad695..69c333b9b5 100644<br>
--- a/tests/lxcxml2xmltest.c<br>
+++ b/tests/lxcxml2xmltest.c<br>
@@ -21,7 +21,7 @@ static virLXCDriver *driver;<br>
struct testInfo {<br>
const char *name;<br>
int different;<br>
- bool inactive_only;<br>
+ bool active_only;<br>
unsigned int parse_flags;<br>
};<br>
<br>
@@ -40,7 +40,7 @@ testCompareXMLToXMLHelper(const void *data)<br>
<br>
ret = testCompareDomXML2XMLFiles(driver->caps, driver->xmlopt, xml_in,<br>
info->different ? xml_out : xml_in,<br>
- !info->inactive_only,<br>
+ info->active_only,<br>
info->parse_flags,<br>
TEST_COMPARE_DOM_XML2XML_RESULT_SUCCESS);<br>
VIR_FREE(xml_in);<br>
@@ -57,9 +57,9 @@ mymain(void)<br>
if (!(driver = testLXCDriverInit()))<br>
return EXIT_FAILURE;<br>
<br>
-# define DO_TEST_FULL(name, is_different, inactive, parse_flags) \<br>
+# define DO_TEST_FULL(name, is_different, active, parse_flags) \<br>
do { \<br>
- const struct testInfo info = {name, is_different, inactive, \<br>
+ const struct testInfo info = {name, is_different, active, \<br>
parse_flags}; \<br>
if (virTestRun("LXC XML-2-XML " name, \<br>
testCompareXMLToXMLHelper, &info) < 0) \<br>
@@ -67,10 +67,10 @@ mymain(void)<br>
} while (0)<br>
<br>
# define DO_TEST(name) \<br>
- DO_TEST_FULL(name, 0, false, 0)<br>
+ DO_TEST_FULL(name, 0, true, 0)<br>
<br>
# define DO_TEST_DIFFERENT(name) \<br>
- DO_TEST_FULL(name, 1, false, 0)<br>
+ DO_TEST_FULL(name, 1, true, 0)<br>
<br>
/* Unset or set all envvars here that are copied in lxcdBuildCommandLine<br>
* using ADD_ENV_COPY, otherwise these tests may fail due to unexpected<br>
-- <br>
2.31.1<br>
<br></blockquote><div><br></div><div>Polite ping <br></div></div></div>