<div dir="ltr"><div>Hi,</div><div>No problem, those patches are RFC.</div><div>If there would be issues with the libvirt interface - qemu patches should not be applied either.<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Aug 20, 2021 at 3:59 PM Michal Prívozník <<a href="mailto:mprivozn@redhat.com">mprivozn@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 8/20/21 2:57 PM, Michal Prívozník wrote:<br>
> On 7/28/21 10:17 AM, Andrew Melnychenko wrote:<br>
>> Added check for qemu virtio-net "ebpf_rss_fds" property.<br>
>> This property allows to pass eBPF program/map file descriptors for RSS program.<br>
>> In other patches, libvirt may launch qemu-ebpf-rss-helper and pass fds<br>
>> to virtio-net qemu.<br>
>><br>
>> Signed-off-by: Andrew Melnychenko <<a href="mailto:andrew@daynix.com" target="_blank">andrew@daynix.com</a>><br>
>> ---<br>
>>  src/qemu/qemu_capabilities.c | 2 ++<br>
>>  src/qemu/qemu_capabilities.h | 1 +<br>
>>  2 files changed, 3 insertions(+)<br>
>><br>
>> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c<br>
>> index 7cd6dab259..f16115226d 100644<br>
>> --- a/src/qemu/qemu_capabilities.c<br>
>> +++ b/src/qemu/qemu_capabilities.c<br>
>> @@ -638,6 +638,7 @@ VIR_ENUM_IMPL(virQEMUCaps,<br>
>>                "query-display-options",<br>
>>                "s390-pv-guest",<br>
>>                "virtio-net.rss",<br>
>> +              "virtio-net.ebpf_rss_fds",<br>
>>      );<br>
>>  <br>
>>  <br>
>> @@ -1423,6 +1424,7 @@ static struct virQEMUCapsDevicePropsFlags virQEMUCapsDevicePropsVirtioNet[] = {<br>
>>      { "packed", QEMU_CAPS_VIRTIO_PACKED_QUEUES, NULL },<br>
>>      { "acpi-index", QEMU_CAPS_ACPI_INDEX, NULL },<br>
>>      { "rss", QEMU_CAPS_VIRTIO_RSS, NULL },<br>
>> +    { "ebpf_rss_fds", QEMU_CAPS_VIRTIO_EBPF_RSS_FDS, NULL },<br>
> <br>
> I haven't found this in QEMU. Looking into qemu-devel list it was<br>
> proposed but apparently is not merged yet:<br>
> <br>
> <a href="https://lists.nongnu.org/archive/html/qemu-devel/2021-07/msg03536.html" rel="noreferrer" target="_blank">https://lists.nongnu.org/archive/html/qemu-devel/2021-07/msg03536.html</a><br>
<br>
Ooops, hit send too early.<br>
<br>
What I wanted to say is that it's perfectly okay to send patches before<br>
QEMU part is merged. However, libvirt part won't be merged before QEMU.<br>
We did this mistake too many times before and learned our lesson.<br>
<br>
Michal<br>
<br>
</blockquote></div>