<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Sep 28, 2021 at 10:43 AM Jie Wang <<a href="mailto:wangjie88@huawei.com">wangjie88@huawei.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">block type CDROM also support startupPolicy in the past, so<br></blockquote><div>s/block/Block/</div><div><br></div><div> "in the past" could be more detailed. It's better if you tell from which version to which version the</div><div>startupPolicy of block type cdrom is supported<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
let us fix it.<br>
<br>
Signed-off-by: Jie Wang <<a href="mailto:wangjie88@huawei.com" target="_blank">wangjie88@huawei.com</a>><br>
---<br>
 src/conf/domain_conf.c | 5 +++--<br>
 1 file changed, 3 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c<br>
index f7025bffe4..dd374e8ab3 100644<br>
--- a/src/conf/domain_conf.c<br>
+++ b/src/conf/domain_conf.c<br>
@@ -30853,9 +30853,10 @@ virDomainDiskTranslateSourcePool(virDomainDiskDef *def)<br>
     }<br>
<br>
     if (def->startupPolicy != 0 &&<br>
-        virStorageSourceGetActualType(def->src) != VIR_STORAGE_TYPE_FILE) {<br>
+        (virStorageSourceGetActualType(def->src) != VIR_STORAGE_TYPE_FILE &&<br>
+         virStorageSourceGetActualType(def->src) != VIR_STORAGE_TYPE_BLOCK)) {<br>
         virReportError(VIR_ERR_XML_ERROR, "%s",<br>
-                       _("'startupPolicy' is only valid for 'file' type volume"));<br>
+                       _("'startupPolicy' is only valid for 'file' or 'block' type volume"));<br>
         return -1;<br>
     }<br>
<br>
-- <br>
2.24.0.windows.2<br>
<br>
<br>
</blockquote></div></div>