<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Oct 14, 2021 at 5:53 PM Michal Prívozník <<a href="mailto:mprivozn@redhat.com">mprivozn@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 10/11/21 2:54 AM, Han Han wrote:<br>
> <br>
> <br>
> On Mon, Oct 11, 2021 at 3:50 AM Peter Krempa <<a href="mailto:pkrempa@redhat.com" target="_blank">pkrempa@redhat.com</a><br>
> <mailto:<a href="mailto:pkrempa@redhat.com" target="_blank">pkrempa@redhat.com</a>>> wrote:<br>
> <br>
>     On Sat, Oct 09, 2021 at 17:37:42 +0800, Han Han wrote:<br>
>     > The qemu capability will be used for the page_per_vq option of virtio<br>
>     > devices.<br>
>     ><br>
>     > Signed-off-by: Han Han <<a href="mailto:hhan@redhat.com" target="_blank">hhan@redhat.com</a> <mailto:<a href="mailto:hhan@redhat.com" target="_blank">hhan@redhat.com</a>>><br>
>     > ---<br>
>     >  src/qemu/qemu_capabilities.c                       | 6 ++++++<br>
>     >  src/qemu/qemu_capabilities.h                       | 1 +<br>
>     >  tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml   | 1 +<br>
>     >  tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml  | 1 +<br>
> <br>
>     NACK,<br>
> <br>
> OK. BTW, where to check the least version of qemu that libvirt supports?<br>
<br>
libvirt.git $ grep QEMU_MIN src/qemu/qemu_capabilities.c<br>
#define QEMU_MIN_MAJOR 2<br>
#define QEMU_MIN_MINOR 11<br>
#define QEMU_MIN_MICRO 0<br>
<br>
<br>
So can you please post v3 and fix also the signed-off we've talked about<br>
earlier? Thanks.<br></blockquote><div>OK. v3: <a href="https://listman.redhat.com/archives/libvir-list/2021-October/msg00666.html">https://listman.redhat.com/archives/libvir-list/2021-October/msg00666.html</a> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Michal<br>
<br>
</blockquote></div></div>