<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=Windows-1252"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="#0563C1" vlink="#954F72" style="word-wrap:break-word"> <div class="WordSection1"> On 2/22/22, 1:19 AM, "Michal Prívozník" <mprivozn@redhat.com> wrote:<o:p></o:p> <o:p> </o:p> > On 2/16/22 11:25, Michal Prívozník wrote:<o:p></o:p> > <o:p></o:p> > >> diff --git a/tests/qemuxml2argvdata/sgx-epc.x86_64-6.2.0.args b/tests/qemuxml2argvdata/sgx-epc.x86_64-6.2.0.args<o:p></o:p> > >> new file mode 100644<o:p></o:p> > >> index 0000000000..e1aa274054<o:p></o:p> > >> --- /dev/null<o:p></o:p> > >> +++ b/tests/qemuxml2argvdata/sgx-epc.x86_64-6.2.0.args<o:p></o:p> > >> @@ -0,0 +1,38 @@<o:p></o:p> > >> +LC_ALL=C \<o:p></o:p> > >> +PATH=/bin \<o:p></o:p> > >> +HOME=/tmp/lib/domain--1-QEMUGuest1 \<o:p></o:p> > >> +USER=test \<o:p></o:p> > >> +LOGNAME=test \<o:p></o:p> > >> +XDG_DATA_HOME=/tmp/lib/domain--1-QEMUGuest1/.local/share \<o:p></o:p> > >> +XDG_CACHE_HOME=/tmp/lib/domain--1-QEMUGuest1/.cache \<o:p></o:p> > >> +XDG_CONFIG_HOME=/tmp/lib/domain--1-QEMUGuest1/.config \<o:p></o:p> > >> +/usr/bin/qemu-system-x86_64 \<o:p></o:p> > >> +-name guest=QEMUGuest1,debug-threads=on \<o:p></o:p> > >> +-S \<o:p></o:p> > >> +-object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/tmp/lib/domain--1-QEMUGuest1/master-key.aes"}' \<o:p></o:p> > >> +-machine pc-q35-6.2,usb=off,dump-guest-core=off,memory-backend=pc.ram \<o:p></o:p> > >> +-accel tcg \<o:p></o:p> > >> +-cpu qemu64 \<o:p></o:p> > >> +-m 134 \<o:p></o:p> > >> +-object '{"qom-type":"memory-backend-ram","id":"pc.ram","size":140509184}' \<o:p></o:p> > >> +-overcommit mem-lock=off \<o:p></o:p> > >> +-smp 1,sockets=1,cores=1,threads=1 \<o:p></o:p> > >> +-object '{"qom-type":"memory-backend-epc","id":"memepc0","prealloc":true,"size":67108864}' \<o:p></o:p> > >> +-object '{"qom-type":"memory-backend-epc","id":"memepc1","prealloc":true,"size":16777216}' \<o:p></o:p> > >> +-M sgx-epc.0.memdev=memepc0,sgx-epc.1.memdev=memepc1 \<o:p></o:p> > > <o:p></o:p> > > I don't think this is correct. IIUC, this can be passed to -machine<o:p></o:p> > > directly, e.g.:<o:p></o:p> > > <o:p></o:p> > > -machine<o:p></o:p> > > pc-q35-6.2,usb=off,dump-guest-core=off,memory-backend=pc.ram,sgx-epc.0.memdev=memepc0,sgx-epc.1.memdev=memepc1<o:p></o:p> > > <o:p></o:p> > > And when I try to do that, I get:<o:p></o:p> > > <o:p></o:p> > > qemu-system-x86_64: Parameter 'sgx-epc.0.node' is missing<o:p></o:p> > > <o:p></o:p> > > Any idea, what's going on? I would much rather avoid using -M if we can<o:p></o:p> > > help it.<o:p></o:p> > > <o:p></o:p> > <o:p></o:p> > One more thing. I've enabled SGX on my machine hoping to test this out,<o:p></o:p> > but my attempts are failing so far. Firstly, with these patches qemu is<o:p></o:p> > unhappy, because .node attribute is missing:<o:p></o:p> > <o:p></o:p> > /home/zippy/work/qemu/qemu.git/build/qemu-system-x86_64 \<o:p></o:p> > <o:p></o:p> > -machine pc-i440fx-4.0,usb=off,dump-guest-core=off \<o:p></o:p> > -accel kvm \<o:p></o:p> > -cpu host,migratable=on \<o:p></o:p> > -m size=4194304k,slots=16,maxmem=1099511627776k \<o:p></o:p> > <o:p></o:p> > -object '{"qom-type":"memory-backend-memfd","id":"memepc0","hugetlb":true,"hugetlbsize":2097152,"prealloc":true,"size":67108864,"host-nodes":[0],"policy":"bind"}' \<o:p></o:p> > -M sgx-epc.0.memdev=memepc0 \<o:p></o:p> > <o:p></o:p> > qemu-system-x86_64: Parameter 'sgx-epc.0.node' is missing<o:p></o:p> <o:p> </o:p> Did you use qemu latest master branch here for experiments? NUMA<o:p></o:p> support is added in qemu master branch, which requires 'sgx-epc.0.node' <o:p></o:p> parameter, but not in its latest 6.2.0 release.<o:p></o:p> <o:p> </o:p> So here I didn’t add 'sgx-epc.0.node' parameter to align with qemu 6.2.0.<o:p></o:p> NUMA support could be separate patch after qemu new release. The other<o:p></o:p> options is we add NUMA support at this time. Any suggestions?<o:p></o:p> <o:p> </o:p> > <o:p></o:p> > But okay, I can add .node, but that doesn't get me much further:<o:p></o:p> > <o:p></o:p> > /home/zippy/work/qemu/qemu.git/build/qemu-system-x86_64 \<o:p></o:p> > <o:p></o:p> > -machine pc-i440fx-4.0,usb=off,dump-guest-core=off \<o:p></o:p> > -accel kvm \<o:p></o:p> > -cpu host,migratable=on \<o:p></o:p> > -m size=4194304k,slots=16,maxmem=1099511627776k \<o:p></o:p> > <o:p></o:p> > -object '{"qom-type":"memory-backend-memfd","id":"memepc0","hugetlb":true,"hugetlbsize":2097152,"prealloc":true,"size":67108864,"host-nodes":[0],"policy":"bind"}' \<o:p></o:p> > -M sgx-epc.0.memdev=memepc0,sgx-epc.0.node=0 \<o:p></o:p> > <o:p></o:p> > qemu-system-x86_64: Invalid parameter type for 'memdev', expected: memory-backend-epc<o:p></o:p> <o:p> </o:p> I think I fixed this kind of issue by moving memory-backend-epc type check before hugetlb<o:p></o:p> check. Could you pls share your domain xml, so I can reproduce it on my side? Thanks.<o:p></o:p> <o:p> </o:p> Thanks,<o:p></o:p> Lin. <o:p></o:p> </div> </body> </html>