<meta http-equiv="Content-Type" content="text/html; charset=utf-8"><div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-size:large">Hi, all! </div><div class="gmail_default" style="font-size:large"><br></div><div class="gmail_default" style="font-size:large">What do you think?</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">пн, 14 февр. 2022 г. в 15:19, Nikolay Shirokovskiy <<a href="mailto:nshirokovskiy@virtuozzo.com">nshirokovskiy@virtuozzo.com</a>>:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The patch series based on discussion in RFC [1].<br>
<br>
I wonder if we'd better add some property like "transient logs" instead<br>
of adding a flag to destoy API.<br>
<br>
Yes libguestfs uses virDomainDestroyFlags to terminate a VM and it is<br>
intended client of this new flag but it or other clients may want to use<br>
shutdown API or use autodestroy domains with same log behaviour. Then<br>
for the current task we only need to support this property in domain xml<br>
I guess.<br>
<br>
[1] removing VMs logs<br>
<a href="https://listman.redhat.com/archives/libvir-list/2022-February/msg00273.html" rel="noreferrer" target="_blank">https://listman.redhat.com/archives/libvir-list/2022-February/msg00273.html</a><br>
<br>
Nikolay Shirokovskiy (3):<br>
libvirt: introduce VIR_DOMAIN_DESTROY_REMOVE_LOGS flag<br>
qemu: support VIR_DOMAIN_DESTROY_REMOVE_LOGS flag<br>
tools: support --remove-logs flag on destroing domain<br>
<br>
docs/manpages/virsh.rst | 7 +++++-<br>
include/libvirt/libvirt-domain.h | 1 +<br>
src/libvirt-domain.c | 6 +++++<br>
src/qemu/qemu_domain.c | 41 ++++++++++++++++++++++++++++++++<br>
src/qemu/qemu_domain.h | 4 ++++<br>
src/qemu/qemu_driver.c | 8 ++++++-<br>
tools/virsh-domain.c | 8 ++++++-<br>
7 files changed, 72 insertions(+), 3 deletions(-)<br>
<br>
-- <br>
2.31.1<br>
<br>
</blockquote></div></div>