<div dir="ltr"><div dir="ltr">Hi Jonathon<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Mar 24, 2022 at 11:26 PM Jonathon Jongsma <<a href="mailto:jjongsma@redhat.com">jjongsma@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">This patch series enables support for the qemu-vdagent character device which<br>
enables copy/paste support between guest and client when using vnc graphics.<br>
<br>
The guest must be configured with something like the following:<br>
<br>
<channel type='qemu-vdagent'><br>
<source><br>
<clipboard copypaste='yes'/><br>
<mouse mode='client'/><br>
</source><br>
<target type='virtio' name='com.redhat.spice.0'/><br>
</channel><br>
<br>
Copy/paste sync requires a vnc client that has support for copy/paste commands.<br>
Currently virt-viewer does not work, but the version of tigervnc provided by<br>
fedora (executable name 'vncviewer') does work.<br>
<br>
More details about this device on Gerd's blog:<br>
<a href="https://www.kraxel.org/blog/2021/05/qemu-cut-paste/" rel="noreferrer" target="_blank">https://www.kraxel.org/blog/2021/05/qemu-cut-paste/</a><br>
<br>
For now I have left the target to be configurable to match the spicevmc<br>
channel, although Marc-Andre has suggested to simply hard-code it to the virtio<br>
name com.redhat.spice.0<br>
<br>
Changes in v2:<br>
- change xml syntax to use <clipboard> and <mouse> sub-elements of <source><br>
defined in the same way as they are for the spice display.<br>
- fix a build failure when apparmor was enabled<br>
- Add another test for when features are turned off<br>
<br></blockquote><div><br></div><div>Is there anything missing to merge this? <br></div><div>thanks</div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Jonathon Jongsma (4):<br>
qemu: add capability for qemu-vdagent chardev<br>
Rename virDomainGraphicsSpiceMouseMode to virDomainMouseMode<br>
conf: add qemu-vdagent channel<br>
qemu: add support for qemu-vdagent channel<br>
<br>
docs/formatdomain.rst | 23 ++++++<br>
src/conf/domain_conf.c | 70 +++++++++++++++++--<br>
src/conf/domain_conf.h | 24 ++++---<br>
src/conf/domain_validate.c | 1 +<br>
src/conf/schemas/domaincommon.rng | 51 +++++++++-----<br>
src/libvirt_private.syms | 4 +-<br>
src/libxl/libxl_conf.c | 8 +--<br>
src/libxl/xen_xl.c | 16 ++---<br>
src/qemu/qemu_capabilities.c | 2 +<br>
src/qemu/qemu_capabilities.h | 1 +<br>
src/qemu/qemu_command.c | 32 +++++++--<br>
src/qemu/qemu_monitor_json.c | 27 +++++++<br>
src/qemu/qemu_process.c | 1 +<br>
src/qemu/qemu_validate.c | 9 +++<br>
src/security/security_apparmor.c | 2 +<br>
src/security/security_dac.c | 2 +<br>
.../caps_6.1.0.x86_64.xml | 1 +<br>
.../caps_6.2.0.aarch64.xml | 1 +<br>
.../caps_6.2.0.x86_64.xml | 1 +<br>
.../caps_7.0.0.x86_64.xml | 1 +<br>
...l-qemu-vdagent-features.x86_64-latest.args | 41 +++++++++++<br>
.../channel-qemu-vdagent-features.xml | 37 ++++++++++<br>
.../channel-qemu-vdagent.x86_64-latest.args | 41 +++++++++++<br>
.../qemuxml2argvdata/channel-qemu-vdagent.xml | 37 ++++++++++<br>
tests/qemuxml2argvtest.c | 2 +<br>
...el-qemu-vdagent-features.x86_64-latest.xml | 58 +++++++++++++++<br>
.../channel-qemu-vdagent.x86_64-latest.xml | 58 +++++++++++++++<br>
tests/qemuxml2xmltest.c | 2 +<br>
tests/testutilsqemu.c | 1 +<br>
29 files changed, 500 insertions(+), 54 deletions(-)<br>
create mode 100644 tests/qemuxml2argvdata/channel-qemu-vdagent-features.x86_64-latest.args<br>
create mode 100644 tests/qemuxml2argvdata/channel-qemu-vdagent-features.xml<br>
create mode 100644 tests/qemuxml2argvdata/channel-qemu-vdagent.x86_64-latest.args<br>
create mode 100644 tests/qemuxml2argvdata/channel-qemu-vdagent.xml<br>
create mode 100644 tests/qemuxml2xmloutdata/channel-qemu-vdagent-features.x86_64-latest.xml<br>
create mode 100644 tests/qemuxml2xmloutdata/channel-qemu-vdagent.x86_64-latest.xml<br>
<br>
-- <br>
2.35.1<br>
<br>
<br>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="gmail_signature">Marc-André Lureau<br></div></div>