<div dir="ltr"><div>sorry for the confusing commit message, it should have been "domain_conf: extend switch in virDomainChrDefFree()" only:D</div><div><br></div><div>Kristina<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jul 21, 2022 at 12:46 PM Kristina Hanicova <<a href="mailto:khanicov@redhat.com">khanicov@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Switch is used for just one case, but a more future proof<br>
approach is to handle all enum values.<br>
<br>
Signed-off-by: Kristina Hanicova <<a href="mailto:khanicov@redhat.com" target="_blank">khanicov@redhat.com</a>><br>
---<br>
 src/conf/domain_conf.c | 7 +++++--<br>
 1 file changed, 5 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c<br>
index b903dac1cb..41eb105a6c 100644<br>
--- a/src/conf/domain_conf.c<br>
+++ b/src/conf/domain_conf.c<br>
@@ -2904,7 +2904,7 @@ void virDomainChrDefFree(virDomainChrDef *def)<br>
     if (!def)<br>
         return;<br>
<br>
-    switch (def->deviceType) {<br>
+    switch ((virDomainChrDeviceType)def->deviceType) {<br>
     case VIR_DOMAIN_CHR_DEVICE_TYPE_CHANNEL:<br>
         switch (def->targetType) {<br>
         case VIR_DOMAIN_CHR_CHANNEL_TARGET_TYPE_GUESTFWD:<br>
@@ -2918,7 +2918,10 @@ void virDomainChrDefFree(virDomainChrDef *def)<br>
         }<br>
         break;<br>
<br>
-    default:<br>
+    case VIR_DOMAIN_CHR_DEVICE_TYPE_PARALLEL:<br>
+    case VIR_DOMAIN_CHR_DEVICE_TYPE_SERIAL:<br>
+    case VIR_DOMAIN_CHR_DEVICE_TYPE_CONSOLE:<br>
+    case VIR_DOMAIN_CHR_DEVICE_TYPE_LAST:<br>
         break;<br>
     }<br>
<br>
-- <br>
2.35.3<br>
<br>
</blockquote></div>