<html><head><style>div {font-size: 12pt; color: #000000; font-family:微软雅黑;}</style></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div style="word-wrap: break-word;"><div style="word-wrap: break-word;"><div style="word-wrap: break-word;"><font face="微软雅黑">Having two branches in the same if structure with</font></div><div style="word-wrap: break-word;"><font face="微软雅黑">the same implementation is at best duplicate code,</font></div><div style="word-wrap: break-word;"><font face="微软雅黑">and at worst a coding error.If the same logic is truly</font></div><div style="word-wrap: break-word;"><font face="微软雅黑">needed for both instances, then they should be combined.</font></div><div style="word-wrap: break-word;"><font face="微软雅黑"><br></font></div><div style="word-wrap: break-word;"><font face="微软雅黑">Signed-off-by: dinglimin <dinglimin@cmss.chinamobile.com></font></div><div style="word-wrap: break-word;"><font face="微软雅黑"><br></font></div><div style="word-wrap: break-word;"><font face="微软雅黑">---</font></div><div style="word-wrap: break-word;"><font face="微软雅黑">v1 of:</font></div><div style="word-wrap: break-word;"><font face="微软雅黑">https://www.mail-archive.com/libvir-list@redhat.com/msg232231.html</font></div><div style="word-wrap: break-word;"><font face="微软雅黑">diff to v1:</font></div><div style="word-wrap: break-word;"><font face="微软雅黑">- Add the patch 's description.</font></div><div style="word-wrap: break-word;"><font face="微软雅黑">- Change the code format.</font></div><div style="word-wrap: break-word;"><font face="微软雅黑">---</font></div><div style="word-wrap: break-word;"><font face="微软雅黑"> scripts/apibuild.py | 6 ++----</font></div><div style="word-wrap: break-word;"><font face="微软雅黑"> 1 file changed, 2 insertions(+), 4 deletions(-)</font></div><div style="word-wrap: break-word;"><font face="微软雅黑"><br></font></div><div style="word-wrap: break-word;"><font face="微软雅黑">diff --git a/scripts/apibuild.py b/scripts/apibuild.py</font></div><div style="word-wrap: break-word;"><font face="微软雅黑">index c232b4e2c8..140916ec4c 100755</font></div><div style="word-wrap: break-word;"><font face="微软雅黑">--- a/scripts/apibuild.py</font></div><div style="word-wrap: break-word;"><font face="微软雅黑">+++ b/scripts/apibuild.py</font></div><div style="word-wrap: break-word;"><font face="微软雅黑">@@ -1248,10 +1248,8 @@ class CParser:</font></div><div style="word-wrap: break-word;"><font face="微软雅黑"> token[1] == "," or token[1] == "="):</font></div><div style="word-wrap: break-word;"><font face="微软雅黑"> self.index_add_ref(oldtok[1], self.filename,</font></div><div style="word-wrap: break-word;"><font face="微软雅黑"> 0, "type")</font></div><div style="word-wrap: break-word;"><font face="微软雅黑">- elif oldtok[0] == "name" and oldtok[1][0:4] == "XEN_":</font></div><div style="word-wrap: break-word;"><font face="微软雅黑">- self.index_add_ref(oldtok[1], self.filename,</font></div><div style="word-wrap: break-word;"><font face="微软雅黑">- 0, "typedef")</font></div><div style="word-wrap: break-word;"><font face="微软雅黑">- elif oldtok[0] == "name" and oldtok[1][0:7] == "LIBXEN_":</font></div><div style="word-wrap: break-word;"><font face="微软雅黑">+ elif oldtok[0] == "name" and (oldtok[1][0:4] == "XEN_" or</font></div><div style="word-wrap: break-word;"><font face="微软雅黑">+ oldtok[1][0:7] == "LIBXEN_"):</font></div><div style="word-wrap: break-word;"><font face="微软雅黑"> self.index_add_ref(oldtok[1], self.filename,</font></div><div style="word-wrap: break-word;"><font face="微软雅黑"> 0, "typedef")</font></div><div style="word-wrap: break-word;"><font face="微软雅黑"><br></font></div><div style="word-wrap: break-word;"><font face="微软雅黑">-- </font></div><div style="word-wrap: break-word;"><font face="微软雅黑">2.18.4</font></div></div><div style="color: rgb(0, 0, 0); font-family: 微软雅黑; font-size: 12pt; word-wrap: break-word;"><br></div><div style="color: rgb(0, 0, 0); font-family: 微软雅黑; font-size: 12pt; word-wrap: break-word;"><br></div></div><div id="SIGNNAME31481"></div><div><span id="_THINKMAILNAME31481" font-size:12pt;font-family:microsoft="" yahei;=""><p><br></p><hr color="#b5c4df" size="1" align="left" style="font-family: 微软雅黑; font-size: 14px; line-height: 21px; width: 210px; height: 1px;"><div style="font-family: 微软雅黑; font-size: 14px; line-height: 21px;"><div style="margin: 10px; font-family: verdana; font-size: 10pt;"><div style="font-size: 10pt;"><span style="font-size: 12px; line-height: normal;">丁丽敏 IaaS</span><span style="font-size: 12px; line-height: normal;">产品部</span></div><div style="font-family: 微软雅黑; font-size: 14px;"><font face="Microsoft YaHei"><span style="font-size: 12px; line-height: normal;">中国移动云能力中心</span></font></div><div style="font-family: 微软雅黑; font-size: 14px;"><span style="font-family: 'Microsoft YaHei'; font-size: 12px; line-height: normal;">电话</span><span style="font-family: 'lucida Grande', Verdana; font-size: 12px; line-height: 18px;">:188-9672-5914</span></div><div style="font-family: 微软雅黑; font-size: 14px;"><span style="font-family: 'lucida Grande', Verdana; font-size: 12px; line-height: 18px;">邮箱:</span><span style="text-align: justify; font-size: 9pt; line-height: 18px; font-family: 微软雅黑, sans-serif;">dinglimin</span><span lang="EN-US" style="text-align: justify; font-size: 9pt; line-height: 18px; font-family: 微软雅黑, sans-serif;">@cmss.chinamobile.com</span></div><div style="font-family: 微软雅黑; font-size: 14px;"><div style="position: static !important;"><span style="font-family: 微软雅黑, sans-serif; font-size: 12px; line-height: 18px; text-align: justify;">江苏省苏州市高新区科技城昆仑山路</span><span lang="EN-US" style="font-family: 微软雅黑, sans-serif; font-size: 12px; line-height: 18px; text-align: justify;">58</span><span style="font-family: 微软雅黑, sans-serif; font-size: 12px; line-height: 18px; text-align: justify;">号</span><span lang="EN-US" style="font-family: 微软雅黑, sans-serif; font-size: 12px; line-height: 18px; text-align: justify;"> </span><span style="font-family: 微软雅黑, sans-serif; font-size: 12px; line-height: 18px; text-align: justify;">中移软件园</span><span lang="EN-US" style="font-family: 微软雅黑, sans-serif; font-size: 12px; line-height: 18px; text-align: justify;"> 215153</span></div></div></div></div><style>div{ font-size:12pt; font-family: Microsoft YaHei; color: black;}</style><div style="font-Size:12pt; font-family:微软雅黑; color:#000000;word-wrap:break-word;x-overflow:hidden;"><font color="#000000"> <br></font></div><style>div{ font-size:12pt; font-family: Microsoft YaHei; color: black;}</style></span></div></body></html>