<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@DengXian";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word">
<div class="WordSection1">
<div>
<p class="MsoNormal">On Thu, Sep 22, 2022 at 04:35:51PM +0200, Martin Kletzander wrote:<o:p></o:p></p>
<p class="MsoNormal">> >On Tue, Sep 13, 2022 at 12:30:31PM -0700, Lin Yang wrote:<o:p></o:p></p>
<p class="MsoNormal">> >>AMX was introduced in QEMU commit 1f16764f7d4515bfd5e4ae0aae814fa280a7d0c8<o:p></o:p></p>
<p class="MsoNormal">> >>and following commits.<o:p></o:p></p>
<p class="MsoNormal">> ><o:p></o:p></p>
<p class="MsoNormal">> >Some of them not pushed yet I believe:<o:p></o:p></p>
<p class="MsoNormal">> ><o:p></o:p></p>
<p class="MsoNormal">> >https://lists.gnu.org/archive/html/qemu-devel/2022-08/msg01936.html<o:p></o:p></p>
<p class="MsoNormal">> ><o:p></o:p></p>
<p class="MsoNormal">> >Otherwise the patch looks good (I'm not sure what's the planned usage of<o:p></o:p></p>
<p class="MsoNormal">> >the python script, but this patch just adds features that'd be missing<o:p></o:p></p>
<p class="MsoNormal">> >in the future, so I think it's fine).<o:p></o:p></p>
<p class="MsoNormal">> ><o:p></o:p></p>
<p class="MsoNormal">> >Reviewed-by: Martin Kletzander <mkletzan@redhat.com><o:p></o:p></p>
<p class="MsoNormal">> ><o:p></o:p></p>
<p class="MsoNormal">> <o:p></o:p></p>
<p class="MsoNormal">> I still can't see the other commits in QEMU mentioning the other<o:p></o:p></p>
<p class="MsoNormal">> features, but I can't see how those missing could cause an issue, so in<o:p></o:p></p>
<p class="MsoNormal">> the end I removed the "and following commits".<o:p></o:p></p>
<p class="MsoNormal">> <o:p></o:p></p>
<p class="MsoNormal">> We also require a Signed-off-by for contributions as written in our<o:p></o:p></p>
<p class="MsoNormal">> contribution guidelines:<o:p></o:p></p>
<p class="MsoNormal">> <o:p></o:p></p>
<p class="MsoNormal">> https://libvirt.org/hacking.html<o:p></o:p></p>
<p class="MsoNormal">> <o:p></o:p></p>
<p class="MsoNormal">> If you say I can add one for you with the current e-mail address there's<o:p></o:p></p>
<p class="MsoNormal">> no need to resend this patch and I can add it before pushing.<o:p></o:p></p>
<p class="MsoNormal">> <o:p></o:p></p>
<p class="MsoNormal">> Thanks for the patch.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Totally okay to me. Please sign with “Lin Yang <lin.a.yang@intel.com>".<o:p></o:p></p>
<p class="MsoNormal">Thank you so much for reviewing this patch.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
<p class="MsoNormal">Lin.<o:p></o:p></p>
</div>
</div>
</body>
</html>