<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Mar 8, 2023 at 12:17 PM Michal Privoznik <<a href="mailto:mprivozn@redhat.com">mprivozn@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Since qemuxml2argvtest is  now using virnumamock, there's no need<br>
for qemuxml2argvmock to offer reimplementation of virNuma*()<br>
functions. Also, the comment about CLang and FreeBSD (introduced<br>
in v4.3.0-40-g77ac204d14) is no longer true.  Looks like noinline<br>
attribute was the missing culprit.<br>
<br>
Signed-off-by: Michal Privoznik <<a href="mailto:mprivozn@redhat.com" target="_blank">mprivozn@redhat.com</a>><br>
---<br>
 src/util/virnuma.h                            |  2 +-<br>
 ...-unavailable-restrictive.x86_64-latest.err |  2 +-<br>
 ...mnode-unavailable-strict.x86_64-latest.err |  2 +-<br>
 ...umatune-static-nodeset-exceed-hostnode.err |  2 +-<br>
 tests/qemuxml2argvmock.c                      | 41 -------------------<br>
 5 files changed, 4 insertions(+), 45 deletions(-)<br></blockquote><div><br></div><div>I think you can also drop include of virnuma.h in tests/qemuxml2argvmock.c</div><div><br></div><div><div>Reviewed-by: Kristina Hanicova <<a href="mailto:khanicov@redhat.com" target="_blank">khanicov@redhat.com</a>> <br></div><font style="--darkreader-inline-color: #b2a696;" color="#888888"><div><br></div><div>Kristina</div></font></div></div></div>