<!DOCTYPE HTML> <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> <meta http-equiv="X-UA-Compatible" content="ie=edge"> <meta name="viewport" content="width=device-width, initial-scale=1"> <style>#repo-username-link:visited{color:#333333} #repo-username-link:hover{color:#333333} #repo-username-link:active{color:#333333} #branch-name-link:visited{color:#333333} #branch-name-link:hover{color:#333333} #branch-name-link:active{color:#333333} .success:visited{color:#32D282} .success:hover{color:#32D282} .success:active{color:#32D282} .failure:visited{color:#DB4545} .failure:hover{color:#DB4545} .failure:active{color:#DB4545} .error:visited{color:#666766} .error:hover{color:#666766} .error:active{color:#666766} #changeset-link:visited{color:#0068FF} #changeset-link:hover{color:#0068FF} #changeset-link:active{color:#0068FF} #documentation-link:visited{color:#0068FF} #documentation-link:hover{color:#0068FF} #documentation-link:active{color:#0068FF} #configuration-link:visited{color:#9EA3A8} #configuration-link:hover{color:#9EA3A8} #configuration-link:active{color:#9EA3A8} #email-footer-section a:active{color:#9EA3A8} #email-footer-section a:hover{color:#9EA3A8} #email-footer-section a:visited{color:#9EA3A8}</style></head> <body style="min-width: 100%;height: 100%;margin: 0;padding: 0;"> <table id="travis-ci-email-container" align="center" border="0" cellpadding="0" cellspacing="0" height="100%" width="100%" style="height:100%;width:100%;padding:10px;font-family:'Source Sans Pro', 'Helvetica Neue', Helvetica, Arial, sans-serif;line-height:150%;text-align:center;color:#333333;background-color:#F4F5F9;background-image:url('https://s3.amazonaws.com/travis-email-assets/build_background.png');height: 100%;width: 100%;padding: 10px;font-family: 'Source Sans Pro', 'Helvetica Neue', Helvetica, Arial, sans-serif;line-height: 150%;text-align: center;color: #333333;background-color: #F4F5F9;background-image: url(https://s3.amazonaws.com/travis-email-assets/build_background.png);"> <tr> <td align="center" valign="top" style="padding-bottom: 20px;"> <table id="email-content-container" border="0" cellpadding="0" cellspacing="0" style="width:500px;padding:32px;background-color:#FFFFFF;width: 500px; padding: 32px; background-color: #FFFFFF;">  <tr> <td id="repo-username-section" align="center" valign="top" style="padding-bottom:20px;padding-bottom: 20px;"> <a href="https://travis-ci.org/libvirt/libvirt?utm_source=email&utm_medium=notification" id="repo-username-link" style="color:#333333;text-decoration:none;border-bottom:1px solid #333333;padding-bottom:4px;color: #333333; border-bottom: 1px solid #333333; text-decoration: none; padding-bottom: 4px;"> <p class="repo-slug" style="margin:0px;font-size:30px;font-weight:600;line-height:36px;padding-left:5px;display: inline; font-size: 30px; font-weight: 600; line-height: 36px; padding-right: 5px; padding-left: 0px;">libvirt</p> <p id="repo-slug-divider" style="margin:0px;font-size:30px;font-weight:100;color:#9EA3A8;display: inline; font-size: 30px; font-weight: 100; color: #9EA3A8;">/</p> <p class="repo-slug" style="margin:0px;font-size:30px;font-weight:600;line-height:36px;padding-left:5px;display: inline; font-size: 30px; font-weight: 600; line-height: 36px; padding-left: 5px;">libvirt</p> </a> </td> </tr>  <tr> <td id="branch-name-section" align="center" valign="top" style="padding-bottom: 35px;"> <p id="branch-name" style="margin:0px;font-size:28px;font-weight:300;margin: 0px; font-size: 28px; font-weight: 300;"> <img alt="branch icon" src="https://s3.amazonaws.com/travis-email-assets/branch.png" style="width:16px;height:auto;padding-right:8px;vertical-align:bottom;width: 16px; height: auto; padding-right: 8px; vertical-align: bottom;"><a href="https://github.com/libvirt/libvirt/tree/v4.1-maint" id="branch-name-link" style="color:#333333;text-decoration:none;border-bottom:1px solid #333333;text-decoration: none; border-bottom: 1px solid #333333; padding-bottom: 2px;">v4.1-maint</a> </p> </td> </tr>  <tr> <td align="center" valign="top" style="padding-bottom: 20px;"> <table cellpadding="0" cellspacing="0" class="build-status-border build-status-border-error" style="border-radius:3px;border:1px solid #666766;width: 100%;"> <tr class="build-status-background-error" style="background:rgba(102, 103, 102, 0.1)"> <td id="status-icon-section" align="center" valign="top" class="build-status-border-bottom-error" style="border-bottom:1px solid #666766;padding: 15px 15px;"> <div style="float: left;"> <div style="display: inline;"><img alt="build has errored" src="https://s3.amazonaws.com/travis-email-assets/status-errored.png" style="display: inline; vertical-align: sub; width: 17px; height: 17px; padding-right: 8px;"></div><div style="display: inline;"><a href="https://travis-ci.org/libvirt/libvirt/builds/373157167?utm_source=email&utm_medium=notification" class="error" id="status-section-message" style="color:#666766;font-size: 16px; font-weight: 600;">Build #1193 has errored</a></div> </div> <div style="display: inline; float: left;"><img alt="arrow to build time" id="arrow" src="https://s3.amazonaws.com/travis-email-assets/error-arrow.png" style="width: 7px; height: auto; vertical-align: text-bottom; padding: 0px 8px;"></div> <div style="float: right;"> <span><img alt="clock icon" id="build-time-clock-icon" src="https://s3.amazonaws.com/travis-email-assets/time.png" style="width: 15px; height: 17px; padding-right: 8px; vertical-align: sub"></span><span style="font-size: 14px;">22 mins and 52 secs</span> </div> </td> </tr> <tr> <td id="user-avatar-changeset-section" align="center" valign="top" style="padding-bottom:32px;padding: 20px 15px 35px 15px;"> <div id="user-avatar-changeset-left" style="float:left;float: left;"> <p style="margin:0px;display: inline; font-size: 14px; font-weight: 700; color: #333333;"> <img alt="Laine Stump avatar" src="https://secure.gravatar.com/avatar/3095aaebd9ad10be8211f9a4a3d3b97c" style="width: 22px; height: auto; border-radius: 10px; vertical-align: middle; margin-right: 8px;">Laine Stump </p> </div> <div id="user-avatar-changeset-right" style="float:right;float: right;"> <a href="https://github.com/libvirt/libvirt/commit/13969ca54f5c" id="changeset-link" style="font-size:14px;font-weight:600;color:#0068FF;font-size: 14px; color: #0068FF; font-weight: 600;">13969ca CHANGESET →</a> </div> </td> </tr> <tr> <td id="commit-message-section" align="center" valign="top" style="min-height:104px;padding:0px 20px 20px 20px;min-height: 104px; padding: 0px 15px 20px 15px;"> <p id="commit-message" style="margin:0px;font-family:cousine, monospace;font-size:14px;line-height:22px;font-family: cousine, monospace; font-size: 14px; text-align: left; line-height: 22px;">nwfilter: increase pcap buffer size to be compatible with TPACKET_V3<br><br>When an nwfilter rule sets the parameter CTRL_IP_LEARNING to "dhcp",<br>this turns on the "dhcpsnoop" thread, which uses libpcap to monitor<br>traffic on the domain's tap device and extract the IP address from the<br>DHCP response.<br><br>If libpcap on the host is built with HAVE_TPACKET3 defined (to enable<br>support for TPACKET_V3), the dhcpsnoop code's initialization of the<br>libpcap socket would fail with the following error:<br><br> virNWFilterSnoopDHCPOpen:1134 : internal error: pcap_setfilter: can't remove kernel filter: Bad file descriptor<br><br>It turns out that this was because TPACKET_V3 requires a larger buffer<br>size than libvirt was setting (we were setting it to 128k). Changing<br>the buffer size to 256k eliminates the error, and the dhcpsnoop thread<br>once again works properly.<br><br>A fuller explanation of why TPACKET_V3 requires such a large buffer,<br>for future git spelunkers:<br><br>libpcap calls setsockopt(... SOL_PACKET, PACKET_RX_RING...) to setup a<br>ring buffer for receiving packets; two of the attributes sent to this<br>API are called tp_frame_size, and tp_frame_nr. If libpcap was built<br>with HAVE_TPACKET3 defined, tp_trame_size is set to MAXIMUM_SNAPLEN<br>(defined in libpcap sources as 262144) and tp_frame_nr is set to:<br><br> [the buffer size we set, i.e. PCAP_BUFFERSIZE i.e. 262144] / tp_frame_size.<br><br>So if PCAP_BUFFERSIZE < MAXIMUM_SNAPLEN, then tp_frame_nr (the number<br>of frames in the ring buffer) is 0, which is nonsensical. This same<br>value is later used as a multiplier to determine the size for a call<br>to malloc() (which would also fail).<br><br>(NB: if HAVE_TPACKET3 is *not* defined, then tp_frame_size is set to<br>the snaplen set by the user (in our case 576) plus a small amount to<br>account for ethernet headers, so 256k is far more than adequate)<br><br>Since the TPACKET_V3 code in libpcap actually reads multiple packets<br>into each frame, it's not a problem to have only a single frame<br>(especially when we are monitoring such infrequent traffic), so it's<br>okay to set this relatively small buffer size (in comparison to the<br>default, which is 2MB), which is important since every guest using<br>dhcp snooping in a nwfilter rule will hold 2 of these buffers for the<br>entire life of the guest.<br><br>Thanks to Christian Ehrhardt for discovering that buffer size was the<br>problem (this was not at all obvious from the error that was logged!)<br><br>Resolves: https://bugzilla.redhat.com/1547237<br>Fixes: https://bugs.launchpad.net/libvirt/+bug/1758037<br><br>Signed-off-by: Laine Stump <laine@laine.org><br>Reviewed-by: Christian Ehrhardt <christian.ehrhardt@canonical.com> (V1)<br>Reviewed-by: John Ferlan <jferlan@redhat.com><br>Tested-by: Christian Ehrhardt <christian.ehrhardt@canonical.com><br>(cherry picked from commit ce5aebeacd10a1c15cb3ee46a59c8b5ff235589e)</p> </td> </tr> </table> </td> </tr> </table> </td> </tr>  <tr> <td id="system-message-section" align="center" valign="top" style="padding-bottom:20px;padding-bottom: 20px;"> <table id="system-message-container" border="0" cellpadding="0" cellspacing="0" style="width:500px;padding:32px;background-color:#FFFFFF;border:1px solid #0068FF;border-radius:3px;width: 500px; padding: 32px; background-color: #FFFFFF; border: 1px solid #0068FF; border-radius: 3px;"> <tr> <td id="broadcast-logo-section" align="center" valign="top"> <div class="system-message-item" style="padding-bottom: 32px;"> <img alt="broadcast tower image" id="system-message-logo" src="https://s3.amazonaws.com/travis-email-assets/system_message.png" style="width:20px;height:auto;vertical-align:sub;padding-right:8px;padding-right: 8px; width: 20px; height: auto; vertical-align: sub;"> <h2 id="system-message-header" style="font-size:24px;display:inline;font-weight:300;color:#0068FF;margin:0px;display: inline; font-size: 24px; font-weight: 300; color: #0068FF; margin: 0px;">System Message</h2> </div> <div> <img alt=" broadcast indicator" class="broadcast-category-icon" src="https://s3.amazonaws.com/travis-email-assets/warning_dot.png" style="float:left;width:11px;height:auto;margin-right:10px;padding-top:7px;width: 11px; height: auto; float: left; margin-right: 10px; padding-top: 7px;"> </div> <div> <p class="broadcast-message" style="margin:0px;max-width:85%;font-size:16px;font-weight:300;text-align:left;line-height:26px;border-bottom:1px solid #DCDFE2;padding-bottom:20px;margin-bottom:20px;font-size: 16px; line-height: 26px; font-weight: 300; text-align: left; max-width: 85%; border-bottom: 1px solid #DCDFE2; padding-bottom: 20px; margin-bottom: 20px;">We will stop accepting API & Cron build requests for <b>inactive</b> repositories on Tue, May 1st 2018. If you need these requests to be accepted please activate the target repository, or email support@travis-ci.com if you have any questions.</p> </div> </td> </tr> </table> </td> </tr>  <tr> <td id="update-section" align="center" valign="top" style="padding-bottom:20px;padding-bottom: 20px;"> <table id="update-container" border="0" cellpadding="0" cellspacing="0" style="width:500px;padding:32px 32px 42px 32px;background-color:#FFFFFF;width: 500px; padding: 32px 32px 42px 32px; background-color: #FFFFFF"> <tr> <td align="center" valign="top"> <p id="update-header" style="margin:0px;font-size:24px;line-height:31px;margin-bottom:20px;padding-bottom:10px;border-bottom:2px solid #0068FF;border-bottom: 2px solid #0068FF; padding-bottom: 10px; font-size: 24px; line-height: 31px; margin-bottom: 20px;">Want to know about upcoming build environment updates?</p> <p id="update-message" style="margin:0px;font-size:16px;font-weight:300;line-height:26px;margin-bottom:32px;font-size: 16px; line-height: 26px; font-weight: 300; margin-bottom: 32px;">Would you like to stay up-to-date with the upcoming Travis CI build environment updates? We set up a mailing list for you!</p> <a href="http://eepurl.com/9OCsP" id="sign-up-button" style="font-size:14px;font-weight:600;color:#FFFFFF;text-decoration:none;background-color:#0068FF;padding:12px 20px;border-radius:3px;font-size: 14px; font-weight: 600; color: #FFFFFF; background-color: #0068FF; text-decoration: none; padding: 12px 20px; border-radius: 3px;">SIGN UP HERE</a> </td> </tr> </table> </td> </tr>  <tr> <td align="center" valign="top" style="padding-bottom: 20px;"> <table id="documentation-container" border="0" cellpadding="0" cellspacing="0" style="width:500px;padding:25px;background-color:rgba(222,239,255,0.3);border:1px solid #66A4FF;border-radius:3px;width: 500px; padding: 25px; background-color: rgba(222,239,255,0.3); border: 1px solid #66A4FF; border-radius: 3px;"> <tr> <td id="documentation-section" align="center" valign="top"> <div> <img alt="book icon" id="documentation-icon" src="https://s3.amazonaws.com/travis-email-assets/documentation.png" style="display:inline;vertical-align:bottom;padding-right:5px;display: inline; vertical-align: bottom; padding-right: 5px;"> <p id="documentation-text" style="margin:0px;display:inline;font-size:26px;font-weight:300;color:#0068FF;font-size: 26px; font-weight: 300; color: #0068FF; display: inline;"> <a href="https://docs.travis-ci.com/" id="documentation-link" style="color:#0068FF">Documentation</a> about Travis CI </p> </div> </td> </tr> </table> </td> </tr>  <tr> <td align="center" valign="top"> <table id="travis-ci-email-footer-container" border="0" cellpadding="20" cellspacing="0" style="width:500px;width: 500px;"> <tr> <td id="questions-section" align="center" valign="top" style="font-weight:300;color:#0068FF;color:#0068FF; font-weight: 300;"> <span>Have any questions?</span> <span> <a href="mailto:support@travis-ci.com" style="color: #0068FF">We're here to help.</a> </span> </td> </tr> <tr> <td id="travis-ci-footer-logo-section" style="text-align:center;text-align: center;"> <a href="https://travis-ci.com"><img alt="black and white travis ci logo" src="https://s3.amazonaws.com/travis-email-assets/TravisCI-Logo-BW.png"></a> </td> </tr> <tr> <td id="email-footer-section" style="font-size:10px;line-height:200%;text-align:center;color:#9EA3A8;padding-top:0px;color: #9EA3A8; font-size: 10px; line-height: 200%; text-align: center; color: #9EA3A8; padding-top: 0px;"> <p style="margin:0px;margin: 0px;">Travis CI GmbH, Rigaer Str. 8, 10427 Berlin, Germany | GF: Konstantin Haase, Fritz Thielemann | <span>Contact:<a href="mailto:contact@travis-ci.com" style="color:#9EA3A8;color: #9EA3A8;">contact@travis-ci.com</a> | Amtsgericht Charlottenburg, Berlin, HRB 140133 B | Umsatzsteuer-ID gemäß §27 a Umsatzsteuergesetz: DE282002648</span> </p> </td> </tr> </table> </td> </tr> </table> <script type="application/ld+json"> { "@context": "http://schema.org", "@type": "EmailMessage", "action": { "@type": "ViewAction", "url": "https://travis-ci.org/libvirt/libvirt/builds/373157167?utm_source=email&utm_medium=notification", "name": "View Build" }, "description": "View Build #1193 on Travis CI" } </script> <center> <br /> <br /> <br /> <br /> <br /> <br /> <table border="0" cellpadding="0" cellspacing="0" width="100%" id="canspamBarWrapper" style="background-color:#FFFFFF; border-top:1px solid #E5E5E5;"> <tr> <td align="center" valign="top" style="padding-top:20px; padding-bottom:20px;"> <table border="0" cellpadding="0" cellspacing="0" id="canspamBar"> <tr> <td align="center" valign="top" style="color:#606060; font-family:Helvetica, Arial, sans-serif; font-size:11px; line-height:150%; padding-right:20px; padding-bottom:5px; padding-left:20px; text-align:center;"> This email was sent to <a href="mailto:libvirt-ci@redhat.com" target="_blank" style="color:#404040 !important;">libvirt-ci@redhat.com</a> <a href="http://clicks.travis-ci.com/track/unsub.php?u=14313403&id=88958295b11a447bad39e39d4328ca7a.q3yTAF39gfjNcLjHva7iXjXSQZI%3D&r=https%3A%2F%2Fmandrillapp.com%2Funsub%3Fmd_email%3Dlibvirt-ci%2540redhat.com" style="color:#404040 !important;">unsubscribe from this list</a> </td> </tr> </table> </td> </tr> </table> <style type="text/css"> @media only screen and (max-width: 480px){ table[id="canspamBar"] td{font-size:14px !important;} table[id="canspamBar"] td a{display:block !important; margin-top:10px !important;} } </style> </center></body> </html>