<br><tt><font size=2>libvirt-cim-bounces@redhat.com wrote on 2008-11-04
06:13:53:<br>
<br>
> > > > +def run_remote_guest(ip, domain, command):<br>
> > > > + """ Execute commands
on remote guest console.<br>
> > > > + """<br>
> > > > +<br>
> > > > + cmd = 'python %s %s "%s"'
% (CONSOLE_APP_PATH, domain, command)<br>
> > > > +<br>
> > > > + return run_remote(ip, cmd)<br>
> > > > +<br>
> > > > +<br>
> > ><br>
> > > Kaitlin,<br>
> > ><br>
> > > I think we can remove run_remote_guest
to xm_virt_util.py under<br>
> > > ../libvirt-cim/lib/XenKvmLib,<br>
> > > because it have to be used by live.py
under lib/VirtLib. We have<br>
> > > to make it stay in utils.py.<br>
> > <br>
> > I'm sorry, I intend to say we cann't remove
run_remote_guest() from <br>
> > ../lib/XenKvmLib to xm_virt_util.py =)<br>
> > <br>
> > > Thoughts?<br>
> > > <br>
> > > If you agree to make it stay in utils.py,
I will rework on this <br>
> > patch.<br>
> > > Thanks!<br>
> <br>
> I'm sorry Daisy - I'm not sure I understand what you mean here. Are
you <br>
> saying that run_remote_guest() needs to stay in lib/VirtLib/utils.py?<br>
> <br>
> If so, why?</font></tt>
<br>
<br><tt><font size=2> Kaitlin,</font></tt>
<br>
<br><tt><font size=2> I make run_remote_guest() stay in lib/VirtLib/utils
in my patch today. Also </font></tt>
<br><tt><font size=2> I update all related helper functions. If this
function has to be moved to</font></tt>
<br><tt><font size=2> libvirt-cim/lib/XenKvmLib, I will cook up it
on follow up patch.</font></tt>
<br>
<br><tt><font size=2> Thanks!</font></tt>
<br><tt><font size=2> </font></tt>
<br><tt><font size=2> <br>
> <br>
> -- <br>
> Kaitlin Rupert<br>
> IBM Linux Technology Center<br>
> kaitlin@linux.vnet.ibm.com<br>
> <br>
> _______________________________________________<br>
> Libvirt-cim mailing list<br>
> Libvirt-cim@redhat.com<br>
> https://www.redhat.com/mailman/listinfo/libvirt-cim<br>
</font></tt>