<br><font size=2 face="sans-serif">+1 from me.</font>
<br>
<br><font size=2 face="sans-serif">Best,<br>
Regards<br>
<br>
Daisy (Ô˹úÁ«)<br>
VSM Team, China Systems & Technology Labs (CSTL)<br>
E-mail: yunguol@cn.ibm.com<br>
TEL: (86)-21-60922403<br>
Building 10, 399 Ke Yuan Rd, Pudong Shanghai, 201203<br>
</font>
<br>
<br>
<br>
<table width=100%>
<tr valign=top>
<td width=40%><font size=1 face="sans-serif"><b>Kaitlin Rupert <kaitlin@linux.vnet.ibm.com></b>
</font>
<br><font size=1 face="sans-serif">Sent by: libvirt-cim-bounces@redhat.com</font>
<p><font size=1 face="sans-serif">2008-11-06 08:40</font>
<table border>
<tr valign=top>
<td bgcolor=white>
<div align=center><font size=1 face="sans-serif">Please respond to<br>
List for discussion and development of libvirt CIM
<libvirt-cim@redhat.com></font></div></table>
<br>
<td width=59%>
<table width=100%>
<tr valign=top>
<td>
<div align=right><font size=1 face="sans-serif">To</font></div>
<td><font size=1 face="sans-serif">libvirt-cim@redhat.com</font>
<tr valign=top>
<td>
<div align=right><font size=1 face="sans-serif">cc</font></div>
<td>
<tr valign=top>
<td>
<div align=right><font size=1 face="sans-serif">Subject</font></div>
<td><font size=1 face="sans-serif">[Libvirt-cim] [PATCH] [TEST] Fix VSMS
14_define_sys_disk.py to specify FV
or PV disk for Xen guests</font></table>
<br>
<table>
<tr valign=top>
<td>
<td></table>
<br></table>
<br>
<br>
<br><tt><font size=2># HG changeset patch<br>
# User Kaitlin Rupert <karupert@us.ibm.com><br>
# Date 1225932047 28800<br>
# Node ID 78c534011b848cade45897c0c35dac4ebc53fce1<br>
# Parent ddd395416461b33536e9475521548ba8e2c16d84<br>
[TEST] Fix VSMS 14_define_sys_disk.py to specify FV or PV disk for Xen
guests.<br>
<br>
Without this fix, both FV and PV rasds are passed to the DefineSystem()
call<br>
which isn't valid on PV systems.<br>
<br>
Signed-off-by: Kaitlin Rupert <karupert@us.ibm.com><br>
<br>
diff -r ddd395416461 -r 78c534011b84 suites/libvirt-cim/cimtest/VirtualSystemManagementService/14_define_sys_disk.py<br>
--- a/suites/libvirt-cim/cimtest/VirtualSystemManagementService/14_define_sys_disk.py
Tue Nov 04 22:19:33 2008 -0800<br>
+++ b/suites/libvirt-cim/cimtest/VirtualSystemManagementService/14_define_sys_disk.py
Wed Nov 05 16:40:47 2008 -0800<br>
@@ -48,18 +48,22 @@<br>
<br>
return path<br>
<br>
-def get_vssd_rasd(ip, virt, addr):<br>
+def get_vssd_rasd(ip, virt, addr, disk_type):<br>
vssd = get_vssd_mof(virt, test_dom)<br>
<br>
rasds = get_default_rasds(ip, virt)<br>
<br>
- for i in range(len(rasds)):<br>
- if 'DiskPool' in rasds[i]['PoolID']:<br>
- rasds[i]['Address'] = addr<br>
- rasds[i] = inst_to_mof(rasds[i])<br>
+ rasd_list = []<br>
+<br>
+ for rasd in rasds:<br>
+ if 'DiskPool' in rasd['PoolID']:<br>
+ if disk_type != ""
and rasd['Caption'] != disk_type:<br>
+ continue<br>
+ rasd['Address'] = addr<br>
+ rasd_list.append(inst_to_mof(rasd))<br>
<br>
params = { 'vssd' : vssd,<br>
- 'rasd' : rasds<br>
+ 'rasd' : rasd_list <br>
}<br>
<br>
return params <br>
@@ -68,12 +72,19 @@<br>
def main():<br>
options = main.options<br>
<br>
+ if options.virt == "Xen":<br>
+ disk_cap = "PV disk"<br>
+ elif options.virt == "XenFV":<br>
+ disk_cap = "FV disk"<br>
+ else:<br>
+ disk_cap = "" <br>
+<br>
try:<br>
addr = make_long_disk_path(options.ip)<br>
if addr is None:<br>
raise Exception("Unable
to create large disk image")<br>
<br>
- define_params = get_vssd_rasd(options.ip,
options.virt, addr)<br>
+ define_params = get_vssd_rasd(options.ip,
options.virt, addr, disk_cap)<br>
if len(define_params) != 2:<br>
raise Exception("Unable
to get VSSD and RASDs for %s" % test_dom)<br>
<br>
<br>
_______________________________________________<br>
Libvirt-cim mailing list<br>
Libvirt-cim@redhat.com<br>
https://www.redhat.com/mailman/listinfo/libvirt-cim<br>
</font></tt>
<br>