<br><font size=2 face="sans-serif">+1</font>
<br>
<br><font size=2 face="sans-serif">Best,<br>
Regards<br>
<br>
Daisy (Ô˹úÁ«)<br>
VSM Team, China Systems & Technology Labs (CSTL)<br>
E-mail: yunguol@cn.ibm.com<br>
TEL: (86)-21-60922403<br>
Building 10, 399 Ke Yuan Rd, Pudong Shanghai, 201203<br>
</font>
<br>
<br><tt><font size=2>libvirt-cim-bounces@redhat.com wrote on 2009-03-05
05:04:27:<br>
<br>
> # HG changeset patch<br>
> # User Kaitlin Rupert <karupert@us.ibm.com><br>
> # Date 1236200658 28800<br>
> # Node ID ad367dfd38f4a78eeaf5369bb00d22bbf6aec911<br>
> # Parent  e3dd4cec1b61373e738fe3ba58557ae543b41789<br>
> If the resource type of a devices is set to UNKNOWN, do not generateXML
for it<br>
> <br>
> xmlgen was recently refactored, so this adds back in behavior that
was missed<br>
> during the refactor.  If the resource type of a device is <br>
> CIM_RES_TYPE_UNKNOWN,<br>
> then the xml generation for that device should be skipped.<br>
> <br>
> The RemoveResources() call sets a device's type to UNKNOWN to indicate
that<br>
> the device should be marked for removal.<br>
> <br>
> Signed-off-by: Kaitlin Rupert <karupert@us.ibm.com><br>
> <br>
> diff -r e3dd4cec1b61 -r ad367dfd38f4 libxkutil/xmlgen.c<br>
> --- a/libxkutil/xmlgen.c   Tue Mar 03 10:04:00 2009 -0700<br>
> +++ b/libxkutil/xmlgen.c   Wed Mar 04 13:04:18 2009 -0800<br>
> @@ -128,6 +128,10 @@<br>
>          const char *msg = NULL;;<br>
>  <br>
>          for (i = 0; (i < dominfo->dev_disk_ct)
&& (msg == NULL); i++) {<br>
> +                struct virt_device
*dev = &dominfo->dev_disk[i];<br>
> +                if (dev->type
== CIM_RES_TYPE_UNKNOWN)<br>
> +                    
   continue;<br>
> +<br>
>                  struct
disk_device *disk = &dominfo->dev_disk[i].dev.disk;<br>
>                  CU_DEBUG("Disk:
%i %s %s",<br>
>                    
      disk->disk_type,<br>
> @@ -229,6 +233,9 @@<br>
>  <br>
>          for (i = 0; (i < dominfo->dev_net_ct)
&& (msg == NULL); i++) {<br>
>                  struct
virt_device *dev = &dominfo->dev_net[i];<br>
> +                if (dev->type
== CIM_RES_TYPE_UNKNOWN)<br>
> +                    
   continue;<br>
> +<br>
>                  struct
net_device *net = &dev->dev.net;<br>
>  <br>
>                  if (STREQ(dev->dev.net.type,
"network"))<br>
> @@ -331,6 +338,9 @@<br>
>          for (i = 0; i < dominfo->dev_graphics_ct;
i++) {<br>
>                  xmlNodePtr
tmp;<br>
>                  struct
virt_device *_dev = &dominfo->dev_graphics[i];<br>
> +                if (_dev->type
== CIM_RES_TYPE_UNKNOWN)<br>
> +                    
   continue;<br>
> +<br>
>                  struct
graphics_device *dev = &_dev->dev.graphics;<br>
>  <br>
>                  tmp
= xmlNewChild(root, NULL, BAD_CAST "graphics", NULL);<br>
> @@ -353,6 +363,9 @@<br>
>          for (i = 0; i < dominfo->dev_input_ct;
i++) {<br>
>                  xmlNodePtr
tmp;<br>
>                  struct
virt_device *_dev = &dominfo->dev_input[i];<br>
> +                if (_dev->type
== CIM_RES_TYPE_UNKNOWN)<br>
> +                    
   continue;<br>
> +<br>
>                  struct
input_device *dev = &_dev->dev.input;<br>
>  <br>
>                  tmp
= xmlNewChild(root, NULL, BAD_CAST "input", NULL);<br>
> <br>
> _______________________________________________<br>
> Libvirt-cim mailing list<br>
> Libvirt-cim@redhat.com<br>
> https://www.redhat.com/mailman/listinfo/libvirt-cim<br>
</font></tt>