<br><tt><font size=2>libvirt-cim-bounces@redhat.com wrote on 2009-03-09
14:47:41:<br>
<br>
> <br>
> <br>
> yunguol@cn.ibm.com wrote:<br>
> > # HG changeset patch<br>
> > # User Guolian Yun <yunguol@cn.ibm.com><br>
> > # Date 1236320248 28800<br>
> > # Node ID b213dddc93404028075f10d7355c468ec8230274<br>
> > # Parent c6f7256013b97dc57a31312897e45eb3cd8604a7<br>
> > [TEST]#4 Add "AllocationCapabilities" to associate
with ECTP and <br>
> skip KVM_RegisteredProfile association<br>
> ><br>
> ><br>
> > Updates from 3 to 4:<br>
> > Use a variable to assign revision value to be calculated for
comparison<br>
> ><br>
> > Updates from 2 to 3:<br>
> > Add changeset instead of skip the verification of <br>
> KVM_ResourceAllocation to ECTP for all the src versions<br>
> ><br>
> > Tested for KVM/LXC with current sources and rpm on Pegasus<br>
> ><br>
> > Signed-off-by: Guolian Yun<yunguol@cn.ibm.com><br>
> ><br>
> > diff -r c6f7256013b9 -r b213dddc9340 suites/libvirt-<br>
> cim/cimtest/ElementConforms/01_forward.py<br>
> > --- a/suites/libvirt-cim/cimtest/ElementConforms/01_forward.py
<br>
> Tue Mar 03 08:47:40 2009 -0800<br>
> > +++ b/suites/libvirt-cim/cimtest/ElementConforms/01_forward.py
<br>
> Thu Mar 05 22:17:28 2009 -0800<br>
> > @@ -53,7 +53,9 @@<br>
> > test_dom = "domU"<br>
> > bug_sblim = '00007'<br>
> > libvirt_cim_ectp_changes = 686<br>
> > -libvirt_cim_input_graphics_ectp = 773 <br>
> > +libvirt_cim_input_graphics_ectp = 773<br>
> > +libvirt_cim_ac_lower = 796<br>
> > +libvirt_cim_ac_upper = 818<br>
> ><br>
> > def init_managed_ele_values(server, virt):<br>
> > verify_ectp_list = {} <br>
> > @@ -63,7 +65,7 @@<br>
> > curr_cim_rev, changeset = get_provider_version(virt,
server)<br>
> > if curr_cim_rev >= libvirt_cim_ectp_changes:<br>
> > cn_names2 = ["VirtualSystemMigrationService",
"DiskPool",<br>
> "NetworkPool",<br>
> > -
"ProcessorPool", "MemoryPool"]<br>
> > +
"ProcessorPool", "MemoryPool", <br>
> "AllocationCapabilities"]<br>
> > cn_names.extend(cn_names2)<br>
> > if curr_cim_rev >= libvirt_cim_input_graphics_ectp:<br>
> > cn_names.append("ConsoleRedirectionService")<br>
> > @@ -136,6 +138,11 @@<br>
> > if profile.InstanceID not in
unsupp_prof:<br>
> > profiles_instid_list.append(profile.InstanceID)<br>
> ><br>
> > + for prof_id in profiles_instid_list:<br>
> > + if prof_id == "CIM:DSP1041-ResourceAllocation-1.1.0c"
and\<br>
> > + libvirt_cim_ac_lower <=
curr_cim_rev < libvirt_cim_ac_upper:<br>
> > <br>
> Can you please break the libvirt_cim_ac_lower <= curr_cim_rev <
<br>
> libvirt_cim_ac_upper.<br>
> Can you also remove the unused import statements.</font></tt>
<br>
<br><tt><font size=2> I will fix this with a new patch.</font></tt>
<br><tt><font size=2> Deepti - Would you please try to add all your
comments in a patch review? Then I</font></tt>
<br><tt><font size=2> can fix all of them once a time =)<br>
> <br>
> > + profiles_instid_list.remove(prof_id)<br>
> > +<br>
> > return status, profiles_instid_list <br>
> ><br>
> > @do_main(sup_types)<br>
> ><br>
> > _______________________________________________<br>
> > Libvirt-cim mailing list<br>
> > Libvirt-cim@redhat.com<br>
> > https://www.redhat.com/mailman/listinfo/libvirt-cim<br>
> > <br>
> <br>
> -- <br>
> Thanks and Regards,<br>
> Deepti B. Kalakeri<br>
> IBM Linux Technology Center<br>
> deeptik@linux.vnet.ibm.com<br>
> <br>
> _______________________________________________<br>
> Libvirt-cim mailing list<br>
> Libvirt-cim@redhat.com<br>
> https://www.redhat.com/mailman/listinfo/libvirt-cim<br>
</font></tt>