<html><body> +1 Sharad Mishra System x Enablement Linux Technology Center IBM <img width="16" height="16" src="cid:1__=08BBFF76DFEA0D5F8f9e8a93df938@us.ibm.com" border="0" alt="Inactive hide details for Kaitlin Rupert ---06/29/2009 05:00:16 PM---# HG changeset patch">Kaitlin Rupert ---06/29/2009 05:00:16 PM---# HG changeset patch <table width="100%" border="0" cellspacing="0" cellpadding="0"> <tr valign="top"><td style="background-image:url(cid:2__=08BBFF76DFEA0D5F8f9e8a93df938@us.ibm.com); background-repeat: no-repeat; " width="40%"> <ul> <ul> <ul> <ul>Kaitlin Rupert <kaitlin@linux.vnet.ibm.com> Sent by: libvirt-cim-bounces@redhat.com 06/29/2009 05:05 PM <table border="1"> <tr valign="top"><td width="168" bgcolor="#FFFFFF"><div align="center">Please respond to List for discussion and development of libvirt CIM <libvirt-cim@redhat.com></div></td></tr> </table> </ul> </ul> </ul> </ul> </td><td width="60%"> <table width="100%" border="0" cellspacing="0" cellpadding="0"> <tr valign="top"><td width="1%"><img width="58" height="1" src="cid:3__=08BBFF76DFEA0D5F8f9e8a93df938@us.ibm.com" border="0" alt=""> <div align="right">To</div></td><td width="100%"><img width="1" height="1" src="cid:3__=08BBFF76DFEA0D5F8f9e8a93df938@us.ibm.com" border="0" alt=""> libvirt-cim@redhat.com</td></tr> <tr valign="top"><td width="1%"><img width="58" height="1" src="cid:3__=08BBFF76DFEA0D5F8f9e8a93df938@us.ibm.com" border="0" alt=""> <div align="right">cc</div></td><td width="100%"><img width="1" height="1" src="cid:3__=08BBFF76DFEA0D5F8f9e8a93df938@us.ibm.com" border="0" alt=""> </td></tr> <tr valign="top"><td width="1%"><img width="58" height="1" src="cid:3__=08BBFF76DFEA0D5F8f9e8a93df938@us.ibm.com" border="0" alt=""> <div align="right">Subject</div></td><td width="100%"><img width="1" height="1" src="cid:3__=08BBFF76DFEA0D5F8f9e8a93df938@us.ibm.com" border="0" alt=""> [Libvirt-cim] [PATCH 3 of 3] When a guest is modified, raise an indication and set the PreviousInstance prop</td></tr> </table> <table border="0" cellspacing="0" cellpadding="0"> <tr valign="top"><td width="58"><img width="1" height="1" src="cid:3__=08BBFF76DFEA0D5F8f9e8a93df938@us.ibm.com" border="0" alt=""></td><td width="336"><img width="1" height="1" src="cid:3__=08BBFF76DFEA0D5F8f9e8a93df938@us.ibm.com" border="0" alt=""></td></tr> </table> </td></tr> </table> <tt># HG changeset patch # User Kaitlin Rupert <karupert@us.ibm.com> # Date 1245869168 25200 # Node ID 7e1613aaff99b7ff536a9bd0277345bf2d62f4f1 # Parent ca56533192e5a5715c66a8d9ebe0d0fedfe02bd3 When a guest is modified, raise an indication and set the PreviousInstance prop Be sure to get the instance of the guest to modifying the guest. This value is needed when we generate an indication. To test this: Modify a guest and make sure the SourceInstance and PreviousInstance values differ and are correctly set. Signed-off-by: Kaitlin Rupert <karupert@us.ibm.com> diff -r ca56533192e5 -r 7e1613aaff99 src/Virt_ComputerSystem.c --- a/src/Virt_ComputerSystem.c Mon Jun 29 17:05:05 2009 -0700 +++ b/src/Virt_ComputerSystem.c Wed Jun 24 11:46:08 2009 -0700 @@ -680,6 +680,39 @@ DEFAULT_EQ(); DEFAULT_INST_CLEANUP(); +static bool trigger_mod_indication(const CMPIContext *context, + CMPIInstance *prev_inst, + const CMPIObjectPath *ref) +{ + CMPIStatus s = {CMPI_RC_OK, NULL}; + const char *ind_name = "ComputerSystemModifiedIndication"; + CMPIInstance *ind = NULL; + char *type = NULL; + + CU_DEBUG("Preparing ComputerSystem indication"); + + ind = get_typed_instance(_BROKER, + CLASSNAME(ref), + ind_name, + NAMESPACE(ref)); + if (ind == NULL) { + CU_DEBUG("Failed to create ind '%s'", ind_name); + goto out; + } + + CU_DEBUG("Setting PreviousInstance"); + CMSetProperty(ind, "PreviousInstance", + (CMPIValue *)&prev_inst, CMPI_instance); + + type = get_typed_class(CLASSNAME(ref), ind_name); + + s = stdi_raise_indication(_BROKER, context, type, NAMESPACE(ref), ind); + + out: + free(type); + return s.rc == CMPI_RC_OK; +} + static int xen_scheduler_params(struct infostore_ctx *ctx, virSchedParameter **params) { @@ -1068,10 +1101,12 @@ CMPIArgs *argsout) { CMPIStatus s; + CMPIInstance *prev_inst = NULL; uint16_t state; int ret; const char *name = NULL; uint32_t rc = 1; + bool ind_rc; ret = cu_get_u16_arg(argsin, "RequestedState", &state); if (ret != CMPI_RC_OK) { @@ -1088,22 +1123,24 @@ goto out; } + /* Retain original instance of the guest to use for the PreviousInstance attribute when generating an indication. */ + s = get_domain_by_name(_BROKER, reference, name, &prev_inst); + if (s.rc != CMPI_RC_OK || prev_inst == NULL) { + cu_statusf(_BROKER, &s, + CMPI_RC_ERR_INVALID_PARAMETER, + "Unable to get instance for guest '%s'", + name); + goto out; + } + s = __state_change(name, state, reference); if (s.rc == CMPI_RC_OK) { - char *type = NULL; - - type = get_typed_class(CLASSNAME(reference), - "ComputerSystemModifiedIndication"); - - /* Failure to raise the indication is okay */ - stdi_trigger_indication(_BROKER, - context, - type, - NAMESPACE(reference)); + ind_rc= trigger_mod_indication(context, prev_inst, reference); + if (!ind_rc) + CU_DEBUG("Unable to trigger indication"); + rc = 0; - - free(type); } out: CMReturnData(results, &rc, CMPI_uint32); _______________________________________________ Libvirt-cim mailing list Libvirt-cim@redhat.com </tt><tt><a href="https://www.redhat.com/mailman/listinfo/libvirt-cim">https://www.redhat.com/mailman/listinfo/libvirt-cim</a></tt><tt> </tt> </body></html>