<html><body>
<p><tt>> Sharad Mishra wrote:<br>
> > # HG changeset patch<br>
> > # User Sharad Mishra <snmishra@us.ibm.com><br>
> > # Date 1268161766 28800<br>
> > # Node ID 12a2efa271d73ef7ed8d88bb27b39cce2505716a<br>
> > # Parent 3655b03ada11d9e99a1d10b97aaa7cdb737fc493<br>
> > [TEST] Add check to verify StorageVolume InstanceID.<br>
> ><br>
> > This test verifies that the InstanceID of StorageVolume is not <br>
> dependent on the pool path in RASD. Rather it is set by virStorageVolGetPath.<br>
> ><br>
> > Signed-off-by: Sharad Mishra <snmishra@us.ibm.com><br>
> ><br>
> > diff -r 3655b03ada11 -r 12a2efa271d7 suites/libvirt-cim/cimtest/<br>
> ResourcePoolConfigurationService/10_create_storagevolume.py<br>
> > --- a/suites/libvirt-cim/cimtest/ResourcePoolConfigurationService/<br>
> 10_create_storagevolume.py Thu Jan 28 14:00:59 2010 -0800<br>
> > +++ b/suites/libvirt-cim/cimtest/ResourcePoolConfigurationService/<br>
> 10_create_storagevolume.py Tue Mar 09 11:09:26 2010 -0800<br>
> > @@ -236,10 +236,15 @@<br>
> > dp_inst_id, <br>
> > exp_vol_path)<br>
> ><br>
> > + if res[1]['Resource']['InstanceID'] != exp_vol_path:<br>
> > + status = FAIL<br>
> > + else:<br>
> > + status = PASS<br>
> > <br>
> <br>
> This check should be done after the call to <br>
> rpcs_conn.CreateResourceInPool() and res[0] != PASS.</tt><br>
<br>
<tt>Above code lines are after call to CreateResourceInPool and checking for res[0].</tt><br>
<tt><br>
> Also, include some debug messages when the match fails.</tt><br>
<br>
<tt>Agreed, I will do that in next revision of this patch.</tt><br>
<br>
<tt>-Sharad</tt><br>
<tt><br>
> <br>
> > ret = cleanup_pool_vol(server, virt, pool_name, <br>
> > clean_pool, exp_vol_path)<br>
> > if res[0] == PASS and found == 1 and \<br>
> > - ret == PASS and stovol_status == PASS:<br>
> > + ret == PASS and stovol_status == PASS and \<br>
> > + status == PASS:<br>
> > status = PASS<br>
> > else:<br>
> > return FAIL<br>
> ><br>
> > _______________________________________________<br>
> > Libvirt-cim mailing list<br>
> > Libvirt-cim@redhat.com<br>
> > <a href="https://www.redhat.com/mailman/listinfo/libvirt-cim">https://www.redhat.com/mailman/listinfo/libvirt-cim</a><br>
> > <br>
> <br>
> -- <br>
> Thanks and Regards,<br>
> Deepti B. Kalakeri<br>
> IBM Linux Technology Center<br>
> deeptik@linux.vnet.ibm.com<br>
> <br>
> _______________________________________________<br>
> Libvirt-cim mailing list<br>
> Libvirt-cim@redhat.com<br>
> <a href="https://www.redhat.com/mailman/listinfo/libvirt-cim">https://www.redhat.com/mailman/listinfo/libvirt-cim</a><br>
</tt></body></html>