<html><body> +1 code follows coding guidelines, compiles and cimtest "VirtualSystemManagementService - 20_verify_vnc_password.py" passes. Sharad Mishra Open Virtualization Linux Technology Center IBM <tt>libvirt-cim-bounces@redhat.com wrote on 03/21/2011 06:08:00 PM: > Chip Vincent <cvincent@linux.vnet.ibm.com> </tt> <tt>> Sent by: libvirt-cim-bounces@redhat.com > </tt> <tt>> 03/21/11 06:08 PM</tt> <tt>> > Please respond to > List for discussion and development of libvirt CIM <libvirt-cim@redhat.com></tt> <tt>> > To</tt> <tt>> > libvirt-cim@redhat.com</tt> <tt>> > cc</tt> <tt>> > Subject</tt> <tt>> > [Libvirt-cim] [PATCH #2] Add VNC autoport support. Updated patch to > resolve compilation issues, and omit the port property if =1 and > only set autoport=yes</tt> <tt>> > # HG changeset patch > # User Chip Vincent <cvincent@us.ibm.com> > # Date 1300756004 14400 > # Node ID ee92bc70899ca4dd6f169c89edc4d374163f3b4f > # Parent 1ac08805bf69fd5e09db234f61860f986f29e0b9 > Add VNC autoport support. Updated patch to resolve compilation > issues, and omit the port property if =1 and only set autoport=yes. > > Signed-off-by: Chip Vincent <cvincent@us.ibm.com> > > diff --git a/libxkutil/xmlgen.c b/libxkutil/xmlgen.c > --- a/libxkutil/xmlgen.c > +++ b/libxkutil/xmlgen.c > @@ -405,7 +405,11 @@ > if (STREQC(dev->type, "sdl")) > goto out; > > - xmlNewProp(tmp, BAD_CAST "port", BAD_CAST dev->port); > + if (STREQC(dev->port, "-1")) > + xmlNewProp(tmp, BAD_CAST "autoport", BAD_CAST "yes"); > + else > + xmlNewProp(tmp, BAD_CAST "port", BAD_CAST dev->port); > + > xmlNewProp(tmp, BAD_CAST "listen", BAD_CAST dev->host); > xmlNewProp(tmp, BAD_CAST "keymap", BAD_CAST dev->keymap); > > > _______________________________________________ > Libvirt-cim mailing list > Libvirt-cim@redhat.com > <a href="https://www.redhat.com/mailman/listinfo/libvirt-cim">https://www.redhat.com/mailman/listinfo/libvirt-cim</a> </tt></body></html>