<html><body>
<p>Chip,<br>
<br>
Return code is not the issue. It is the error message that had changed. This test compares the error message with the expected error message.<br>
Since libvirt-cim does not care about the actual error message, we are okay there.<br>
<br>
Sharad Mishra<br>
Open Virtualization<br>
Linux Technology Center<br>
IBM<br>
<br>
<tt>libvirt-cim-bounces@redhat.com wrote on 04/01/2011 05:51:47 AM:<br>
<br>
> Chip Vincent <cvincent@linux.vnet.ibm.com> </tt><br>
<tt>> Sent by: libvirt-cim-bounces@redhat.com<br>
> </tt><br>
<tt>> 04/01/11 05:51 AM</tt><br>
<tt>> <br>
> Please respond to<br>
> cvincent@linux.vnet.ibm.com; Please respond to<br>
> List for discussion and development of libvirt CIM <libvirt-cim@redhat.com></tt><br>
<tt>> <br>
> To</tt><br>
<tt>> <br>
> libvirt-cim@redhat.com</tt><br>
<tt>> <br>
> cc</tt><br>
<tt>> <br>
> Subject</tt><br>
<tt>> <br>
> Re: [Libvirt-cim] [PATCH] [TEST] Fixing testcase to account for <br>
> different libvirt error string</tt><br>
<tt>> <br>
> +1. Are changes needed in libvirt-cim to handle this case? That is, will <br>
> a change in libvirt return codes break libvirt-cim?<br>
> <br>
> On 03/31/2011 04:42 PM, Sharad Mishra wrote:<br>
> > # HG changeset patch<br>
> > # User Sharad Mishra<snmishra@us.ibm.com><br>
> > # Date 1301604051 25200<br>
> > # Node ID 6d7dab79f4e8806aea65cb413c4f193cdbfc4f40<br>
> > # Parent f0a7eee4cbe06cc4f618770ac149218a1bddb171<br>
> > [TEST] Fixing testcase to account for different libvirt error string.<br>
> ><br>
> > Noticed that this test was failing on some libvirt versions between<br>
> > 0.7.0 and 0.8.7 because libvirt was returning new error message. Latest<br>
> > libvirt (0.8.7-5) is back to using error string from libvirt versions<br>
> > prior to 0.7.0.<br>
> ><br>
> > Signed-off-by: Sharad Mishra<snmishra@us.ibm.com><br>
> ><br>
> > diff -r f0a7eee4cbe0 -r 6d7dab79f4e8 suites/libvirt-cim/cimtest/<br>
> VirtualSystemManagementService/19_definenetwork_ers.py<br>
> > --- a/suites/libvirt-cim/cimtest/VirtualSystemManagementService/<br>
> 19_definenetwork_ers.py Thu Mar 31 12:32:11 2011 -0700<br>
> > +++ b/suites/libvirt-cim/cimtest/VirtualSystemManagementService/<br>
> 19_definenetwork_ers.py Thu Mar 31 13:40:51 2011 -0700<br>
> > @@ -125,10 +125,17 @@<br>
> > if not ret:<br>
> > status = verify_error(exp_rc, exp_desc, cxml)<br>
> > if status != PASS:<br>
> > - raise Exception('Defing domain with <br>
> invalid %s name %s'<br>
> > - ' gave unexpected rc code %s and '<br>
> > - 'description:\n %s'% <br>
> (nettype, field,<br>
> > - cxml.err_rc, cxml.err_desc))<br>
> > + # There are few libvirt version between 0.7.0<br>
> > + # and 0.8.7 which give following error.<br>
> > + status = verify_error(exp_rc,<br>
> > + 'No Network bridge <br>
> name specified',<br>
> > + cxml)<br>
> > + if status != PASS:<br>
> > + raise Exception('Defining domain with<br>
> invalid %s'<br>
> > + ' name %s gave <br>
> unexpected rc code'<br>
> > + ' %s and description:\n'<br>
> > + ' %s'% (nettype, field,<br>
> > + cxml.err_rc, cxml.err_desc))<br>
> > continue<br>
> > ret = cxml.cim_start(options.ip)<br>
> > if ret:<br>
> ><br>
> > _______________________________________________<br>
> > Libvirt-cim mailing list<br>
> > Libvirt-cim@redhat.com<br>
> > <a href="https://www.redhat.com/mailman/listinfo/libvirt-cim">https://www.redhat.com/mailman/listinfo/libvirt-cim</a><br>
> <br>
> -- <br>
> Chip Vincent<br>
> Open Virtualization<br>
> IBM Linux Technology Center<br>
> cvincent@linux.vnet.ibm.com<br>
> <br>
> _______________________________________________<br>
> Libvirt-cim mailing list<br>
> Libvirt-cim@redhat.com<br>
> <a href="https://www.redhat.com/mailman/listinfo/libvirt-cim">https://www.redhat.com/mailman/listinfo/libvirt-cim</a><br>
</tt></body></html>