<html><body>
<p>Sharad Mishra<br>
Open Virtualization<br>
Linux Technology Center<br>
IBM<br>
<br>
<tt>libvirt-cim-bounces@redhat.com wrote on 06/22/2011 06:26:14 PM:<br>
<br>
> Chip Vincent <cvincent@linux.vnet.ibm.com> </tt><br>
<tt>> Sent by: libvirt-cim-bounces@redhat.com<br>
> </tt><br>
<tt>> 06/22/11 06:26 PM</tt><br>
<tt>> <br>
> Please respond to<br>
> List for discussion and development of libvirt CIM <libvirt-cim@redhat.com></tt><br>
<tt>> <br>
> To</tt><br>
<tt>> <br>
> libvirt-cim@redhat.com</tt><br>
<tt>> <br>
> cc</tt><br>
<tt>> <br>
> Subject</tt><br>
<tt>> <br>
> [Libvirt-cim] [PATCH] Fix AppliedFilterList Associators</tt><br>
<tt>> <br>
> # HG changeset patch<br>
> # User Chip Vincent <cvincent@us.ibm.com><br>
> # Date 1308792349 14400<br>
> # Node ID 26cfeade3cb76c4ee43a7bd33ea456a250c1c1c2<br>
> # Parent a37f80f80d4b2dab73391989168592866c23ba9b<br>
> Fix AppliedFilterList Associators.<br>
> <br>
> Fixed a few small issues relating to reading AppliedFilterList.<br>
> <br>
> Signed-off-by: Chip Vincent <cvincent@us.ibm.com><br>
> <br>
> diff --git a/schema/AppliedFilterList.registration b/schema/<br>
> AppliedFilterList.registration<br>
> --- a/schema/AppliedFilterList.registration<br>
> +++ b/schema/AppliedFilterList.registration<br>
> @@ -1,3 +1,3 @@<br>
> # Copyright IBM Corp. 2011<br>
> # Classname Namespace ProviderName ProviderModule ProviderTypes<br>
> -KVM_AppliedFilterList root/virt Virt_AppliedFilterList <br>
> Virt_AppliedFilterList association<br>
> +KVM_AppliedFilterList root/virt Virt_AppliedFilterList <br>
> Virt_AppliedFilterList instance association<br>
> diff --git a/src/Virt_AppliedFilterList.c b/src/Virt_AppliedFilterList.c<br>
> --- a/src/Virt_AppliedFilterList.c<br>
> +++ b/src/Virt_AppliedFilterList.c<br>
> @@ -218,7 +218,7 @@<br>
> CU_DEBUG("filterref = %s", ndev->filter_ref);<br>
> <br>
> if ((ndev->filter_ref != NULL) &&<br>
> - STREQC(name, ndev->filter_ref)) {<br>
> + STREQC(name, ndev->filter_ref)) {</tt><br>
<br>
<tt>Its a nit, can you fix the indentation above?</tt><br>
<tt><br>
> CU_DEBUG("Getting network device instance");<br>
> <br>
> CMPIInstance *instance = NULL;<br>
> @@ -235,10 +235,10 @@<br>
> CIM_RES_TYPE_NET,<br>
> &instance);<br>
> <br>
> - if (instance != NULL) {<br>
> - CU_DEBUG("adding instance to list");<br>
> + free(device_id);<br>
> +<br>
> + if (instance != NULL)<br>
> inst_list_add(list, instance);<br>
> - }<br>
> }<br>
> }<br>
> <br>
> @@ -317,7 +317,7 @@<br>
> CU_DEBUG("Checking net device '%s' for filterref",<br>
> devices[i].id);<br>
> <br>
> - if (STREQC(device_name, devices[i].id)) {<br>
> + if (STREQC(net_name, devices[i].id)) {<br>
> CMPIInstance *instance = NULL;<br>
> <br>
> CU_DEBUG("Processing %s", ndev->filter_ref);<br>
> @@ -332,18 +332,18 @@<br>
> filter,<br>
> &instance);<br>
> <br>
> + cleanup_filter(filter);<br>
> +<br>
> if (instance != NULL)<br>
> inst_list_add(list, instance);<br>
> -<br>
> }<br>
> <br>
> }<br>
> <br>
> cleanup_virt_devices(&devices, count);<br>
> +<br>
> out:<br>
> -<br>
> free(domain_name);<br>
> - free((char *)device_name);<br>
> free(net_name);<br>
> <br>
> virDomainFree(dom);<br>
> <br>
> _______________________________________________<br>
> Libvirt-cim mailing list<br>
> Libvirt-cim@redhat.com<br>
> <a href="https://www.redhat.com/mailman/listinfo/libvirt-cim">https://www.redhat.com/mailman/listinfo/libvirt-cim</a><br>
</tt></body></html>