<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> </head> <body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; color: rgb(0, 0, 0); font-size: 14px; font-family: Tahoma, sans-serif;"> <div>unsubscribe</div> <div> </div> <div style="font-family:Calibri; font-size:11pt; text-align:left; color:black; BORDER-BOTTOM: medium none; BORDER-LEFT: medium none; PADDING-BOTTOM: 0in; PADDING-LEFT: 0in; PADDING-RIGHT: 0in; BORDER-TOP: #b5c4df 1pt solid; BORDER-RIGHT: medium none; PADDING-TOP: 3pt"> From: William Roberts <<a href="mailto:bill.c.roberts@gmail.com">bill.c.roberts@gmail.com</a>> Date: Friday, November 1, 2013 at 5:10 PM To: Richard Guy Briggs <<a href="mailto:rgb@redhat.com">rgb@redhat.com</a>> Cc: "<a href="mailto:linux-audit@redhat.com">linux-audit@redhat.com</a>" <<a href="mailto:linux-audit@redhat.com">linux-audit@redhat.com</a>> Subject: Re: Format specifier issue when building kernel </div> <div> </div> <div> <div> On Nov 1, 2013 12:58 PM, "Richard Guy Briggs" <<a href="mailto:rgb@redhat.com">rgb@redhat.com</a>> wrote: > > On Fri, Nov 01, 2013 at 12:38:15PM -0400, Richard Guy Briggs wrote: > > On Fri, Nov 01, 2013 at 12:34:55PM -0400, Steve Grubb wrote: > > > On Friday, November 01, 2013 12:24:55 PM Richard Guy Briggs wrote: > > > > On Thu, Oct 31, 2013 at 12:25:55PM -0700, William Roberts wrote: > > > > +char usermsg_format[64] = ""; > > > > > > You might want this ^^^ to be static so its not global in scope. > > > > Yup, good point. Thanks. > > Better yet, make it local to that if statement, but Eric Paris has a far > more readable and elegant solution: > > diff --git a/kernel/audit.c b/kernel/audit.c > @@ -864,8 +864,8 @@ static int audit_receive_msg(struct sk_buff *skb, > struct nlmsghdr *nlh) > } > audit_log_common_recv_msg(&ab, msg_type); > if (msg_type != AUDIT_USER_TTY) > - audit_log_format(ab, > - " msg='%.AUDIT_MESSAGE_TEXT_MAXs'", > + audit_log_format(ab, " msg='%.*s'", > + AUDIT_MESSAGE_TEXT_MAX, > (char *)data); > else { > int size; > > I forgot about the * format specifier... Yeah me too... I think everyone does :-) > > > > -Steve > > > > > > > - RGB > > > > - RGB > > - RGB > > -- > Richard Guy Briggs <<a href="mailto:rbriggs@redhat.com">rbriggs@redhat.com</a>> > Senior Software Engineer > Kernel Security > AMER ENG Base Operating Systems > Remote, Ottawa, Canada > Voice: +1.647.777.2635 > Internal: (81) 32635 > Alt: +1.613.693.0684x3545 > > -- > Linux-audit mailing list > <a href="mailto:Linux-audit@redhat.com">Linux-audit@redhat.com</a> > <a href="https://www.redhat.com/mailman/listinfo/linux-audit">https://www.redhat.com/mailman/listinfo/linux-audit</a> </div> </div> </body> </html>