[Linux-cachefs] Re: [PATCH 1/7] FS-Cache: Provide a filesystem-specific sync'able page bit

Andrew Morton akpm at osdl.org
Fri Apr 21 10:33:29 UTC 2006


David Howells <dhowells at redhat.com> wrote:
>
> Andrew Morton <akpm at osdl.org> wrote:
> 
> > It would be better to rename PG_checked to PG_fs_misc kernel-wide.
> 
> So would deleting PG_checked and changing the PageChecked() macros to:
> 
> 	#define PageChecked(page)		PageFsMisc((page))
> 	#define SetPageChecked(page)		SetPageFsMisc((page))
> 	#define ClearPageChecked(page)		ClearPageFsMisc((page))
> 
> be acceptable?  Or would you rather I replaced those too?
> 

PG_checked is presently a misc bit which only filesystems use.  So yes, I'd
say it's appropriate to remove PageChecked() and friends altogether.

That might break out-of-tree filesystems, but they'll work it out.




More information about the Linux-cachefs mailing list