[Linux-cachefs] Re: [PATCH 5/7] NFS: Use local caching [try #12]

[David Howells]

Chuck Lever <chucklever at gmail.com> wrote:

> > +static uint16_t nfs_server_get_key(const void *cookie_netfs_data,
> > +                                  void *buffer, uint16_t bufmax)
> > +{
> 
> Why don't you use the function declaration style that is used in the
> rest of the NFS client?

Actually, the NFS client has several different styles, and mine's not without
precedent, eg:

extern int nfs3_setxattr(struct dentry *, const char *,
			const void *, size_t, int);

extern ssize_t nfs_direct_IO(int, struct kiocb *, const struct iovec *, loff_t,
			unsigned long);

static inline loff_t
nfs_size_to_loff_t(__u64 size)

> All the parameters belong on one line, don't they?

Depends how much you want to upset those people who tremble with anxiety at
the sight of a line longer than 80 chars.

David