[Linux-cachefs] Re: [PATCH 6/6] Optimise d_find_alias() [try #6]

David Howells dhowells at redhat.com
Tue Mar 7 13:24:24 UTC 2006


Nick Piggin <nickpiggin at yahoo.com.au> wrote:

> Having the smp_rmb() here implies there is some sort of memory barrier
> based synchronisation protocol at a higher level (than this function),
> because you don't actually do anything before them smp_rmb() here.
> 
> So can you comment what that is?

Hmmm... That probably shouldn't be there. I don't think Andrew Morton and I
actually came to an agreement as to whether it's necessary. I don't think it
is, he thought that it was, though he may have changed his mind.

David




More information about the Linux-cachefs mailing list