[Linux-cachefs] [RFC PATCH v2 13/14] NFS: Call fscache_resize_cookie() when inode size changes due to setattr

David Wysochanski dwysocha at redhat.com
Thu Jul 30 21:07:00 UTC 2020


On Thu, Jul 30, 2020 at 4:03 PM David Howells <dhowells at redhat.com> wrote:
>
> David Wysochanski <dwysocha at redhat.com> wrote:
>
> > To be honest I'm not sure about needing a call to fscache_use/unuse_cookie()
> > around the call to fscache_resize_cookie().  If the cookie has a
> > refcount of 1 when it is created, and a file is never opened, so
> > we never call fscache_use_cookie(), what might happen inside
> > fscache_resize_cookie()?  The header on use_cookie() says
>
> I've have afs_setattr() doing use/unuse on the cookie around resize.
>
> David
>

Got it and will be fixed in next series.  Thanks!




More information about the Linux-cachefs mailing list