[Linux-cachefs] [PATCH] fscache: Fix a NULL vs IS_ERR() bug in fscache_alloc_volume()
Dan Carpenter
dan.carpenter at oracle.com
Fri Dec 3 09:56:08 UTC 2021
The fscache_lookup_cache() function does not return NULL, it returns
error pointers.
Fixes: 27beaec4d546 ("fscache: Implement volume registration")
Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
---
fs/fscache/volume.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/fscache/volume.c b/fs/fscache/volume.c
index 4d0c2d43d54f..10f741c2072f 100644
--- a/fs/fscache/volume.c
+++ b/fs/fscache/volume.c
@@ -208,7 +208,7 @@ static struct fscache_volume *fscache_alloc_volume(const char *volume_key,
char *key;
cache = fscache_lookup_cache(cache_name, false);
- if (!cache)
+ if (IS_ERR(cache))
return NULL;
volume = kzalloc(sizeof(*volume), GFP_KERNEL);
--
2.20.1
More information about the Linux-cachefs
mailing list