[Linux-cachefs] [RFC PATCH] netfs: do not get the folio reference twice

xiubli at redhat.com xiubli at redhat.com
Tue Jul 5 02:22:19 UTC 2022


From: Xiubo Li <xiubli at redhat.com>

And also the comment said it will drop the folio references but
the code was increasing it.

Signed-off-by: Xiubo Li <xiubli at redhat.com>
---
 fs/netfs/buffered_read.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/fs/netfs/buffered_read.c b/fs/netfs/buffered_read.c
index 5b93e22397fe..a44a5b3b8d4c 100644
--- a/fs/netfs/buffered_read.c
+++ b/fs/netfs/buffered_read.c
@@ -396,9 +396,6 @@ int netfs_write_begin(struct netfs_inode *ctx,
 	 */
 	ractl._nr_pages = folio_nr_pages(folio);
 	netfs_rreq_expand(rreq, &ractl);
-
-	/* We hold the folio locks, so we can drop the references */
-	folio_get(folio);
 	while (readahead_folio(&ractl))
 		;
 
-- 
2.36.0.rc1



More information about the Linux-cachefs mailing list