<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN"> <HTML><HEAD> <META http-equiv=Content-Type content="text/html; charset=iso-8859-1"> <META content="MSHTML 5.50.4616.200" name=GENERATOR> <STYLE></STYLE> </HEAD> <BODY bgColor=#ffffff> <DIV><FONT face=Arial size=2>Hi,</FONT></DIV> <DIV><FONT face=Arial size=2></FONT> </DIV> <DIV><FONT face=Arial size=2>I'm installing the lvm_1.0.1-rc1 patch to a RedHat install (kernel 2.4.3-12).</FONT></DIV> <DIV><FONT face=Arial size=2></FONT> </DIV> <DIV><FONT face=Arial size=2>After installing the kernel patch, the kernel build was failing on the min and max macros in lvm-snap.c.</FONT></DIV> <DIV><FONT face=Arial size=2>It appears the new version changed the min and max macros in the lvm-internal.h header file to include type. However, it appears that the lvm-snap.c min and max are still using the old definition.</FONT></DIV> <DIV><FONT face=Arial size=2></FONT> </DIV> <DIV><FONT face=Arial size=2>Since I'm not intending to use the snap functionality in the near future. I used this for quick workaround, I just added a snapmin and and snapmax macro definition in lvm-internal.h and changed the instances of min and max in the lvm-snap.c to use the new snapmin and snapmax macros. This allows the kernel to build.</FONT></DIV> <DIV><FONT face=Arial size=2></FONT> </DIV> <DIV><FONT face=Arial size=2>Thanks,</FONT></DIV> <DIV><FONT face=Arial size=2>David Lightsey</FONT></DIV> <DIV><FONT face=Arial size=2></FONT> </DIV></BODY></HTML>