<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi, <br>
<br>
I'm not a part of the list or the project, just a random guy
dropping by to say I found one suspicious thing:<br>
<br>
after looking for what 's' size stands for, I found that your <a
href="https://github.com/Jajcus/lvm2/blob/master/tools/lvmcmdline.c#L320">lvmcmdline.c
source code</a> probably assumes that sector size is 512, but
there are various sector sizes out in world (both for the hardware
sector size and logical disk interfaces like SCSI) especially more
and more popular 4096 byte sector size. <br>
<br>
I wonder if apart of lvmcmdline.c above, also other parts of your
software assume that sector size will always be 512. If yes, then I
suggest rethinking if 4k sectors might break some operations in LVM.<br>
<br>
By the way, I understand that when specifying command line parameter
sector size, then it is the same for small 's' as capital 'S',
right? And the same goes for bytes ('b' is the same as 'B'), right?
<br>
<br>
Best regards,<br>
Tomasz Lasko<br>
<br>
<br>
</body>
</html>