[lvm-devel] [PATCH 5/5] Check for NULL pointer

Alasdair G Kergon agk at redhat.com
Tue Oct 26 13:42:44 UTC 2010


On Tue, Oct 26, 2010 at 02:59:26PM +0200, Zdenek Kabelac wrote:
> +			if (!options) {
> +				log_error(INTERNAL_ERROR "Missing options.");
> +				return EINVALID_CMD_LINE;
> +			}

Again - what is the bug here?

options is always non-NULL there surely?

What code path causes that new check to fire?

Nack without a decent explanation in the error message of the *cause* not
the symptom.

Alasdair




More information about the lvm-devel mailing list