<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-size:small">ping 2</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small;color:#000000"><span style="color:rgb(34,34,34)">On Mon, Jun 10, 2019 at 11:16 PM Nir Soffer <<a href="mailto:nsoffer@redhat.com">nsoffer@redhat.com</a>> wrote:</span><br></div></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-size:small;color:rgb(0,0,0)">ping</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, May 29, 2019 at 3:10 PM Nir Soffer <<a href="mailto:nirsof@gmail.com" target="_blank">nirsof@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">We have a mechanism to show only single warning about disabled backup:<br>
<br>
WARNING: This metadata update is NOT backed up<br>
<br>
In oVirt we disable local backup since it does not play well with oVirt<br>
clustered LVM solution, and this warning is not helpful. We can filter<br>
the message in oVirt logs, but I think the right place to fix this is in<br>
LVM.<br>
<br>
Add LVM_SUPPRESS_BACKUP_WARNINGS environment variable. If set, suppress<br>
also the first warning about disable backup.<br>
---<br>
lib/format_text/archiver.c | 3 +++<br>
man/lvm.8_main | 4 ++++<br>
2 files changed, 7 insertions(+)<br>
<br>
diff --git a/lib/format_text/archiver.c b/lib/format_text/archiver.c<br>
index 052c2bd2b..0ea8d5e48 100644<br>
--- a/lib/format_text/archiver.c<br>
+++ b/lib/format_text/archiver.c<br>
@@ -196,10 +196,13 @@ int backup_init(struct cmd_context *cmd, const char *dir,<br>
log_error("Couldn't copy backup directory name.");<br>
return 0;<br>
}<br>
backup_enable(cmd, enabled);<br>
<br>
+ if (getenv("LVM_SUPPRESS_BACKUP_WARNINGS"))<br>
+ cmd->backup_params->suppress = 1;<br>
+<br>
return 1;<br>
}<br>
<br>
void backup_exit(struct cmd_context *cmd)<br>
{<br>
diff --git a/man/lvm.8_main b/man/lvm.8_main<br>
index 3e67b1bdf..43ce5150c 100644<br>
--- a/man/lvm.8_main<br>
+++ b/man/lvm.8_main<br>
@@ -470,10 +470,14 @@ together allow automated test scripts to discard uninteresting log data.<br>
.TP<br>
.B LVM_SUPPRESS_LOCKING_FAILURE_MESSAGES<br>
Used to suppress warning messages when the configured locking is known<br>
to be unavailable.<br>
.TP<br>
+.B LVM_SUPPRESS_BACKUP_WARNINGS<br>
+Used to suppress warning messages when automatic metadata backup is<br>
+disabled.<br>
+.TP<br>
.B DM_ABORT_ON_INTERNAL_ERRORS<br>
Abort processing if the code detects a non-fatal internal error.<br>
.TP<br>
.B DM_DISABLE_UDEV<br>
Avoid interaction with udev. LVM will manage the relevant nodes in /dev<br>
-- <br>
2.17.2<br>
<br>
</blockquote></div>
</blockquote></div></div>