[PATCH] Fix for concurrent rpc_method_invoke()

[Alexander Sack]

On Mon, Oct 06, 2008 at 09:44:56AM +0200, Alexander Sack wrote:
> Hi,
> 
> On Mon, Oct 06, 2008 at 06:45:41AM +0200, Gwenole Beauchesne wrote:
> > Le 6 oct. 08 à 01:44, Warren Togami a écrit :
> >
> >> Hunk #1 succeeded at 137 (offset -29 lines).
> >> Hunk #2 succeeded at 187 (offset -3 lines).
> >> patch unexpectedly ends in middle of line
> >> patch: **** malformed patch at line 1724:
> >>
> >> Is the patch you sent malformed?
> >
> > It was manually edited to remove excess from svn diff -r646:HEAD but it 
> > applies fine here (on top of rev 646). Hmm, I edited it on MacOS X so it 
> > probably contains extra UTF-8 characters?
> >
> > Here is the same one with a ChangeLog entry but regenerated from within 
> > Linux. I don't know if that'd really help though.
> 
> this patch applied more or less cleanly to our ubuntu packages. I
> think it works better now.
>  
> Here an excerpt of from the console output i still see. Are those
> VisualID errors because I do not have the latest patches?

OK, I added the

        * src/npw-viewer.c (create_window_attributes): Get system
        visual when we are passed a 0 visual ID.

hunk posted earlier and the visualID issues are gone. Works even
better. Thanks. Any idea where the "Message type invalid" might stem
from?

*** NSPlugin Viewer  *** ERROR: NPN_GetValue() invoke: Message type
invalid

Also the following output looks a bit scary?

*** NSPlugin Wrapper *** ERROR: NPObject 0x44ac7b0 is not valid!



Here the complete console output:

*** NSPlugin Viewer  *** ERROR: NPN_GetValue() invoke: Message type
invalid
*** NSPlugin Viewer  *** WARNING: unhandled variable 14 in
NPN_GetValue()
*** NSPlugin Viewer  *** ERROR: NPN_InvalidateRect() invoke: Message
type invalid
*** NSPlugin Viewer  *** ERROR: NPN_InvalidateRect() invoke: Message
type invalid
*** NSPlugin Viewer  *** ERROR: NPN_InvalidateRect() invoke: Message
type invalid
*** NSPlugin Wrapper *** ERROR: passing an unknown instance
rpc_method_invoke: Connection reset by peer
*** NSPlugin Wrapper *** ERROR: NPClass::Invalidate() invoke:
Connection reset by peer
*** NSPlugin Wrapper *** ERROR: NPP_Destroy() invoke: Connection
closed

(firefox:30934): GLib-CRITICAL **: g_hash_table_remove_internal:
assertion `hash_table != NULL' failed
*** NSPlugin Wrapper *** ERROR: NPObject 0x44ac7b0 is not valid!
*** NSPlugin Wrapper *** ERROR: NPP_Destroy() invoke: Connection
closed

(firefox:30934): GLib-CRITICAL **: g_hash_table_remove_internal:
assertion `hash_table != NULL' failed
*** NSPlugin Wrapper *** ERROR: NPObject 0x24551e0 is not valid!
*** NSPlugin Wrapper *** ERROR: NPP_Destroy() invoke: Connection
closed

(firefox:30934): GLib-CRITICAL **: g_hash_table_remove_internal:
assertion `hash_table != NULL' failed
*** NSPlugin Wrapper *** ERROR: NPObject 0x3f8ff10 is not valid!
*** NSPlugin Wrapper *** ERROR: NPP_Destroy() invoke: Connection
closed



 - Alexander