event patch

[Gwenole Beauchesne]

Hi Martin,

Le 21 oct. 08 à 15:05, Martin Stransky a écrit :

> I'm going to remove the sleep patch from fedora for now. But I'm  
> going to use a different patch - it's attached. It removes the limit  
> of processed events from xt_event_polling_timer_callback handler.

For the records, I have attached a patch I already sent you I think  
but there is still one problem with it. Basically, the old sleep patch  
introduced two regressions in older plugins: one with jpeg2k plugin,  
another one with djvulibre. The former was due to an Xt timeout. The  
other is relevant for an Xt input. Unfortunately, run-time detecting  
internal Xt structs for that is a nightmare. So, removing the patch is  
a current better alternative. ;-)

> I've tested it with flash 9&10 and pdf plugin. CPU usage was the  
> same as  w/o this patch but plug-ins (from my impression) behave  
> more smoothly. Especially if I switched among different tabs/apps.

That's a good thing I think. If the timeout handler calls into the  
browser, it should work now that RPC is concurrent aware. However, it  
does not resolve our other issues yet but makes them less frequent. I  
will work on that case again later.

> It doesn't matter for calls via. RPC but it's a problem when browser  
> and plugin are connected via. npruntime (npclass_bridge), because  
> pointers to already released memory (the handlers) are stored in  
> browser internal NPObject and it still calls them...

Talking about using released memory in NPObject (or others), I wonder  
if someone already ran npviewer.bin with some MALLOC_PERTURB_ set. I  
think there are cases where we reuse memory that was just released. I  
will try this evening. It should be an interesting intermediate test  
before valgrind'ing (it reports too many problems not necessarily  
caused by npviewer).

Regards,
Gwenole.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: npw.sleep.diff
Type: application/octet-stream
Size: 4841 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/nspluginwrapper-devel-list/attachments/20081029/181e9354/attachment.obj>
-------------- next part --------------