From wtogami at redhat.com Mon Sep 15 02:48:27 2008 From: wtogami at redhat.com (Warren Togami) Date: Sun, 14 Sep 2008 22:48:27 -0400 Subject: test Message-ID: <48CDCCFB.10108@redhat.com> test From wtogami at redhat.com Mon Sep 29 23:10:22 2008 From: wtogami at redhat.com (Warren Togami) Date: Mon, 29 Sep 2008 19:10:22 -0400 Subject: Testing the List Message-ID: <48E1605E.8010407@redhat.com> Testing the list. Please disregard. Warren Togami wtogami at redhat.com From wtogami at redhat.com Mon Sep 29 23:17:15 2008 From: wtogami at redhat.com (Warren Togami) Date: Mon, 29 Sep 2008 19:17:15 -0400 Subject: [PATCH] Fix for Flash 10 windowless mode In-Reply-To: <33D179E8-49A4-4224-8B06-27BFD18FA6F8@free.fr> References: <7D74DD4B-8B01-42E5-9016-51F9658987BC@free.fr> <33D179E8-49A4-4224-8B06-27BFD18FA6F8@free.fr> Message-ID: <48E161FB.2080707@redhat.com> https://www.redhat.com/mailman/listinfo/nspluginwrapper-devel-list The posting address is nspluginwrapper-devel-list at redhat.com. Hi Gwenole, thanks for this patch. What reproducer case would cause a crash prior to this patch? http://news.google.com/ For example, if windowless mode is enabled (by default) in Flash 10, it would cause weird behavior and crashes while watching Youtube videos embedded in Google News. Warren Togami wtogami at redhat.com Gwenole Beauchesne wrote: > Hi, > > It seems this message didn't get through to the list or I am not using > the right address? > > Final-Recipient: rfc822; nspluginwrapper-devel at lists.redhat.com > > Action: failed > Status: 5.0.0 > Diagnostic-Code: X-Postfix; host mx1.redhat.com[66.187.233.31] said: 550 > 5.2.1 > >... Mailbox disabled for > this > recipient (in reply to RCPT TO command) > > D?but du message r?exp?di? : > >> *De : *Gwenole Beauchesne > >> *Date : *30 septembre 2008 00:20:48 HAEC >> *? : *nspluginwrapper-devel at lists.redhat.com >> >> *Objet : **[PATCH] Fix for Flash 10 windowless mode* >> >> Hi, >> >> I have committed the following patch to trunk. I chose to initialize >> ws_info->visual on the viewer side even if the browser side didn't. >> NPAPI doesn't mention that field can be NULL but it doesn't mention it >> should always be non-NULL either. Let's just don't assume plugins >> would check for a NULL visual. Does this patch still cause crashes? >> >> Thanks, >> Gwenole. >> > > ------------------------------------------------------------------------ > >> > -------------- next part -------------- A non-text attachment was scrubbed... Name: nspluginwrapper-xvisualid.patch Type: application/octet-stream Size: 1392 bytes Desc: not available URL: From stransky at redhat.com Tue Sep 30 06:40:37 2008 From: stransky at redhat.com (Martin Stransky) Date: Tue, 30 Sep 2008 08:40:37 +0200 Subject: [PATCH] Fix for Flash 10 windowless mode In-Reply-To: <48E161FB.2080707@redhat.com> References: <7D74DD4B-8B01-42E5-9016-51F9658987BC@free.fr> <33D179E8-49A4-4224-8B06-27BFD18FA6F8@free.fr> <48E161FB.2080707@redhat.com> Message-ID: <48E1C9E5.6040707@redhat.com> Hi, we use a minimal version of this patch in fedora now (just the check in npw-rpc.c) and I forget to propagate it back. Anyway, the gdk_visual_get_system() looks like a nice trick, I'll update our packages. Thanks, ma. Warren Togami wrote: > https://www.redhat.com/mailman/listinfo/nspluginwrapper-devel-list > The posting address is nspluginwrapper-devel-list at redhat.com. > > Hi Gwenole, thanks for this patch. > > What reproducer case would cause a crash prior to this patch? > > http://news.google.com/ > For example, if windowless mode is enabled (by default) in Flash 10, it > would cause weird behavior and crashes while watching Youtube videos > embedded in Google News. > > Warren Togami > wtogami at redhat.com > From gb.public at free.fr Tue Sep 30 07:18:14 2008 From: gb.public at free.fr (gb.public at free.fr) Date: Tue, 30 Sep 2008 09:18:14 +0200 (CEST) Subject: [PATCH] Fix for Flash 10 windowless mode In-Reply-To: <30990814.1356241222758973939.JavaMail.root@spooler5-g27.priv.proxad.net> Message-ID: <9570662.1356521222759094777.JavaMail.root@spooler5-g27.priv.proxad.net> Hi, ----- "Martin Stransky" a ?crit : > we use a minimal version of this patch in fedora now (just the check > in > npw-rpc.c) and I forget to propagate it back. Anyway, the > gdk_visual_get_system() looks like a nice trick, I'll update our > packages. I noticed it in your packages too (hence the ChangeLog) but, in my opinion, that version could lead to problems because ws_info->display would not have been set. You should even have got an error in the viewer. BTW, nspluginwrapper, prior to supporting windowless plugins, always set ws_info->visual too. So, in some way, it's a regression from the previous version. We probably should also set something for ws_info->colormap. I don't know why firefox had ws_info->visual == NULL though, I will check the sources later. IIRC, NPAPI specs mention those for windowless plugins too, so it's my assumption they should be filled in with valid values, though they were not saying that explicitly either. I used a nightly build of firefox trunk (3.1-something) from yesterday. A testcase was (full of Flash!). If you still see problems with that patch, please tell me which site. Thanks. Regards, Gwenole. From wtogami at redhat.com Tue Sep 30 16:26:00 2008 From: wtogami at redhat.com (Warren Togami) Date: Tue, 30 Sep 2008 12:26:00 -0400 Subject: [PATCH] Fix for Flash 10 windowless mode In-Reply-To: <9570662.1356521222759094777.JavaMail.root@spooler5-g27.priv.proxad.net> References: <9570662.1356521222759094777.JavaMail.root@spooler5-g27.priv.proxad.net> Message-ID: <48E25318.9000901@redhat.com> gb.public at free.fr wrote: > > I noticed it in your packages too (hence the ChangeLog) but, in my > opinion, that version could lead to problems because ws_info->display > would not have been set. You should even have got an error in the > viewer. > > BTW, nspluginwrapper, prior to supporting windowless plugins, always > set ws_info->visual too. So, in some way, it's a regression from the > previous version. We probably should also set something for > ws_info->colormap. I don't know why firefox had ws_info->visual == > NULL though, I will check the sources later. IIRC, NPAPI specs > mention those for windowless plugins too, so it's my assumption they > should be filled in with valid values, though they were not saying > that explicitly either. > > I used a nightly build of firefox trunk (3.1-something) from > yesterday. A testcase was (full of Flash!). If > you still see problems with that patch, please tell me which site. > Thanks. > > Regards, Gwenole. Here are two confirmed problems... [root at newcaprica /]# rpm -q firefox nspluginwrapper flash-plugin firefox-3.0.2-1.fc9.x86_64 nspluginwrapper-1.1.0-7.fc9.i386 nspluginwrapper-1.1.0-7.fc9.x86_64 flash-plugin-10.0.0.569-release.i386 http://kojipkgs.fedoraproject.org/packages/nspluginwrapper/1.1.0/7.fc9/ This build uses your new patch. http://news.google.com/ The embedded Youtube videos here begin playing if you click on the "+ Video" links. It seems to expand using javascript to reveal a Youtube video. If you did not disable windowless mode, then it displays with visual glitches and soon dies. It seems to work unwrapped. http://www.theonion.com/content/video/economists_warn_anti_bush This video seems to crash readily if a Flash ad happens in rotation while the video is playing. Warren