From proski at gnu.org Sat Oct 29 19:12:46 2011 From: proski at gnu.org (Pavel Roskin) Date: Sat, 29 Oct 2011 15:12:46 -0400 Subject: [PATCH] Use libdl when linking npplayer Message-ID: <20111029191246.20274.97209.stgit@localhost.localdomain> Without it, following error occurs on Fedora 15 when compiling for x86_64: /usr/bin/ld: npplayer-npw-player.o: undefined reference to symbol 'dlsym@@GLIBC_2.2.5' /usr/bin/ld: note: 'dlsym@@GLIBC_2.2.5' is defined in DSO /lib64/libdl.so.2 so try adding it to the linker command line /lib64/libdl.so.2: could not read symbols: Invalid operation collect2: ld returned 1 exit status Fedora already has a patch that adds -ldl to LDFLAGS Signed-off-by: Pavel Roskin --- Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index e36a991..2a40671 100644 --- a/Makefile +++ b/Makefile @@ -142,7 +142,7 @@ npplayer_CFLAGS += $(GTK_CFLAGS) $(GLIB_CFLAGS) $(MOZILLA_CFLAGS) $(CURL_CFLAGS npplayer_LDFLAGS = $(LDFLAGS) npplayer_LDFLAGS += $(libpthread_LDFLAGS) npplayer_LIBS = $(GTK_LIBS) $(GLIB_LIBS) $(CURL_LIBS) $(X_LIBS) -npplayer_LIBS += $(libpthread_LIBS) $(libsocket_LIBS) +npplayer_LIBS += $(libdl_LIBS) $(libpthread_LIBS) $(libsocket_LIBS) libnoxshm_LIBRARY = libnoxshm.so libnoxshm_RAWSRCS = libnoxshm.c From davidben at mit.edu Sat Oct 29 20:08:46 2011 From: davidben at mit.edu (David Benjamin) Date: Sat, 29 Oct 2011 16:08:46 -0400 Subject: [PATCH] Use libdl when linking npplayer In-Reply-To: <20111029191246.20274.97209.stgit@localhost.localdomain> References: <20111029191246.20274.97209.stgit@localhost.localdomain> Message-ID: Thanks! Applied. David On Sat, Oct 29, 2011 at 3:12 PM, Pavel Roskin wrote: > Without it, following error occurs on Fedora 15 when compiling for > x86_64: > > /usr/bin/ld: npplayer-npw-player.o: undefined reference to symbol > 'dlsym@@GLIBC_2.2.5' > /usr/bin/ld: note: 'dlsym@@GLIBC_2.2.5' is defined in DSO > /lib64/libdl.so.2 so try adding it to the linker command line > /lib64/libdl.so.2: could not read symbols: Invalid operation > collect2: ld returned 1 exit status > > Fedora already has a patch that adds -ldl to LDFLAGS > > Signed-off-by: Pavel Roskin > --- > > ?Makefile | ? ?2 +- > ?1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/Makefile b/Makefile > index e36a991..2a40671 100644 > --- a/Makefile > +++ b/Makefile > @@ -142,7 +142,7 @@ npplayer_CFLAGS ?+= $(GTK_CFLAGS) $(GLIB_CFLAGS) $(MOZILLA_CFLAGS) $(CURL_CFLAGS > ?npplayer_LDFLAGS ?= $(LDFLAGS) > ?npplayer_LDFLAGS += $(libpthread_LDFLAGS) > ?npplayer_LIBS ? ? = $(GTK_LIBS) $(GLIB_LIBS) $(CURL_LIBS) $(X_LIBS) > -npplayer_LIBS ? ?+= $(libpthread_LIBS) $(libsocket_LIBS) > +npplayer_LIBS ? ?+= $(libdl_LIBS) $(libpthread_LIBS) $(libsocket_LIBS) > > ?libnoxshm_LIBRARY = libnoxshm.so > ?libnoxshm_RAWSRCS = libnoxshm.c > > _______________________________________________ > Nspluginwrapper-devel-list mailing list > Nspluginwrapper-devel-list at redhat.com > https://www.redhat.com/mailman/listinfo/nspluginwrapper-devel-list >