<HTML dir=ltr><HEAD><TITLE>Re: [Open-scap] Stubbed implementation of open-scap oval parsing.</TITLE> <META http-equiv=Content-Type content="text/html; charset=unicode"> <META content="MSHTML 6.00.6001.18203" name=GENERATOR></HEAD> <BODY> <DIV id=idOWAReplyText68997 dir=ltr> <DIV dir=ltr>Peter, you are right. This code should be changed. As a matter of stylistic integrity, it seems to me that we would want to deprecate the use of x_ptr classes in the implementation altogether and replace these with the open api struct references that you suggest. Since I am working with this code as an implementation of the oval parsing/population function, I think I would be in the best position to make the suggested changes. A question for the community: Should these changes be implemented before or after a complete parsing implementation is available?</DIV></DIV> <DIV dir=ltr> <HR tabIndex=-1> From: Peter Vrabec [mailto:pvrabec@redhat.com] Sent: Tue 3/17/2009 12:23 PM To: open-scap-list@redhat.com Cc: David Niemoller Subject: Re: [Open-scap] Stubbed implementation of open-scap oval parsing. </DIV> <DIV> Hi David, thnx. a lot for update. :) there is one more thing we would like to change. Example: oval_definitions.h struct oval_definition_s; char *oval_definition_id (struct oval_definition_s*); oval_definition.c char* oval_definition_id (oval_definition_ptr definition) { return ((oval_definition_ptr)definition)->id; } --> oval_definitions.h struct oval_definition; char *oval_definition_id (struct oval_definition*); oval_definition.c char *oval_definition_id (struct oval_definition* definition); return definition->id; } Are you guys OK with that? We can take care of it. Peter. </DIV></BODY></HTML>