<div class="gmail_quote">On Fri, Jul 31, 2009 at 5:12 PM, Joey Boggs <span dir="ltr"><<a href="mailto:jboggs@redhat.com">jboggs@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
This will facilitate the switch to readonly rootfs. The current method will not work when symlinking /etc/mtab to /proc/mounts as the udev label /BOOT is used rather than /dev/sda1 or similar. The same output is generated and has been verified to install correctly.<br>
</blockquote><div><br>We need this symlink even if /etc/mtab is listed in /etc/rwtab ?<br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
# check that /boot mounted ok and find partition number for GRUB<br>
- eval $(mount|awk '$3 == "/boot" { <br></blockquote><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">+ eval $(readlink -f /dev/disk/by-label/BOOT|awk {'</blockquote>
<div><br>This wouldn't check that /boot actually mounted successfully.<br></div><div><br>- print "disk=" substr($1,1,length($1)-1);<br>
- print "disk2=" substr($1,1,length($1)-2);<br>
- partN=substr($1,length($1),1); partN--;<br>
- print "partN=" partN;<br>
- }')<br>+ print "disk=" substr($1,1,length($1)-1);<br>
+ print "disk2=" substr($1,1,length($1)-2);<br>
+ partN=substr($1,length($1),1); partN--;<br>
+ print "partN=" partN;<br>
+ '})<br>
</div><br>This whitespace only change obscures the real change, please put in a separate patch, but IMHO fixing indentation is not need here.<br><br></div>