<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
On 02/11/2010 11:35 AM, Mike Burns wrote:
<blockquote cite="mid:1265906149.3058.3.camel@localhost.localdomain"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<meta name="GENERATOR" content="GtkHTML/3.28.2">
On Thu, 2010-02-11 at 11:19 -0500, Joey Boggs wrote:
<blockquote type="CITE">
<pre>---
scripts/ovirt-config-storage | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/ovirt-config-storage b/scripts/ovirt-config-storage
index 9c3f773..10a4066 100755
--- a/scripts/ovirt-config-storage
+++ b/scripts/ovirt-config-storage
@@ -291,7 +291,7 @@ EOF
printf "Aborting"
return
elif [[ $mb_input =~ ^-*[0-9]+$ ]]; then
- if [[ $mb_input -ge $min_size || $mb_input =~ $part_regexp ]] \
+ if [[ $mb_input -ge $min_size || $mb_input =~ $part_regexp && $mb_input -ne 0 ]] \
&& [[ $mb_input -le $space_left ]] ; then
eval "$size_var=$mb_input"
size_used=$mb_input
</pre>
</blockquote>
<br>
If we're not supporting 0, we should also remove this:<br>
<br>
diff --git a/scripts/ovirt-config-storage b/scripts/ovirt-config-storage<br>
index be22ef6..1a50ea9 100755<br>
--- a/scripts/ovirt-config-storage<br>
+++ b/scripts/ovirt-config-storage<br>
@@ -238,8 +238,7 @@ do_configure()<br>
fi<br>
printf "\n\nPlease configure storage partitions.\n\n"<br>
printf "* Enter partition sizes in MB.\n"<br>
- printf "* A value of 0 indicates the partition should be
disabled.\n"<br>
- printf "* If the partition is enabled, it will have a minimum
valid size.\n<br>
+ printf "* All partitions have a minimum valid size.\n"<br>
printf "* Size remaining value is approximate due to cylinder
rounding\n"<br>
printf " during partitioning.\n"<br>
printf "* For the Data partition, a size of -1 indicates that
the\n"<br>
<br>
<br>
</blockquote>
I pulled this in from downstream, so I figured there would be some
discussion around this patch. Should there be support for 0MB sized
partitions? If not then I'll update the patch with the comments
suggested.<br>
</body>
</html>