<div dir="ltr">Alright. One more question.<div><span style="color:rgb(80,0,80)">Setting in_reply_to here is the right thing to do for how the code</span><br style="color:rgb(80,0,80)"><span style="color:rgb(80,0,80)">behaves right now. However, the real problem is that it's missing in</span><br style="color:rgb(80,0,80)"><span style="color:rgb(80,0,80)">MessageSerializer! Can you add it, and here do:</span><br style="color:rgb(80,0,80)"><br style="color:rgb(80,0,80)"><span style="color:rgb(80,0,80)"> if 'in_reply_to' not in validated_data:</span><br style="color:rgb(80,0,80)"><span style="color:rgb(80,0,80)"> msg.in_reply_to = m.get_in_reply_to() or ""</span></div><div><span style="caret-color: rgb(80, 0, 80);"><font color="#000000"><br></font></span></div><div><span style="caret-color: rgb(80, 0, 80);"><font color="#000000">Is this same for every field? </font></span>msg.stripped_subject ,msg.version, msg.prefixes, msg.is_series_head ......<div><br><div class="gmail_quote"><div dir="ltr">On Mon, May 7, 2018 at 4:42 PM Paolo Bonzini <<a href="mailto:pbonzini@redhat.com">pbonzini@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">On 07/05/2018 13:03, Shubham Jain wrote:<br>
> <br>
> <br>
> On Mon, May 7, 2018 at 4:25 PM Paolo Bonzini <<a href="mailto:pbonzini@redhat.com" target="_blank">pbonzini@redhat.com</a><br>
> <mailto:<a href="mailto:pbonzini@redhat.com" target="_blank">pbonzini@redhat.com</a>>> wrote:<br>
> <br>
> On 05/05/2018 09:09, Shubham Jain wrote:<br>
> > This commit allows to create/POST message from browser<br>
> > - Add "create" method to MessageManager so that it calls save_mbox()<br>
> > - Add getter and setter for mbox<br>
> > - Rename the existing "mbox" field to e.g. "mbox_blob"<br>
> > - Fix nested writable serializer issue<br>
> <br>
> This already looks pretty good, but:<br>
> <br>
> - there are no test cases<br>
> <br>
> I was thinking of doing this when we have POST for both json and<br>
> text/plain format. <br>
<br>
No, please do it immediately. Every patch should have testcases if<br>
applicable.<br>
<br>
> - we should use it as an exercise in posting a series composed of<br>
> multiple changes<br>
> <br>
> I still don't know how to send the multiple patches in a single patch. <br>
<br>
Good, that's what I wanted to know! :)<br>
<br>
You can do<br>
<br>
git format-patch -opatches-post --cover-letter origin/master..<br>
<br>
"-o" gives the output directory. "--cover-letter" says that you want to<br>
include an introductory message.<br>
<br>
Now edit "patches-post/0000-cover-letter.patch" to include the<br>
introductory message, and then<br>
<br>
git send-mbox *whatever options you need* patches-post/*<br>
<br>
Do you know how to split a patch in multiple parts? The idea is<br>
<br>
git add -p<br>
... add changes for the first patch ...<br>
git stash --keep-index<br>
... test ...<br>
git commit -a<br>
git stash pop<br>
<br>
and repeat until the last part is missing. Then just:<br>
<br>
... test ...<br>
git commit -a<br>
<br>
to commit the last part.<br>
<br>
But again, it's okay (perhaps better for your comfort) if you first do<br>
the requested changes and then we work on testcases and posting<br>
splitting the patches. This way, the mailing list post also acts as a<br>
sort of backup. :)<br>
<br>
Paolo<br>
</blockquote></div></div></div></div>