<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 12/08/11 18:25, Adam Young wrote:
<blockquote cite="mid:4EE171B0.70801@redhat.com" type="cite">
<meta http-equiv="Context-Type" content="text/html;
charset=ISO-8859-1">
On 12/08/2011 03:00 PM, Adam Young wrote:
<blockquote cite="mid:4EE11750.2020103@redhat.com" type="cite"> On
12/07/2011 11:07 AM, Adam Young wrote:
<blockquote cite="mid:4EDF8F58.5080708@redhat.com" type="cite">On
11/16/2011 10:38 AM, Adam Young wrote: <br>
<blockquote type="cite">On 11/16/2011 09:48 AM, Ade Lee wrote:
<br>
<blockquote type="cite">I'm struggling with the premise
behind this patch. Some of these <br>
methods seem like they are valuable - and certainly they
were valuable <br>
at some point in time (or they would not have been
written). On the <br>
other hand, I see the benefit of trimming the code base.
No need to <br>
refactor code that isn't being used. <br>
<br>
I realize that this removes some eclipse warnings, but is
removing these <br>
methods good practice? <br>
<br>
I guess I'm looking for some other folks to chime in here.
<br>
</blockquote>
<br>
My feeling is that you do not leave dead code in the code
base. The code still exists in the repository, but it is
unlikely that a piece of code that is not called today will
be needed in exactly the same form in the future. <br>
<br>
<br>
Code is documentation. Code that is not used is misleading
to the maintainer. Committing commented out code is a bad
practice. <br>
<br>
As we refactor, the location of the behavior of a lot of
these methods will change. Thus, some orphan calls will
become uncallable, and others will get in the way of code
clean up. <br>
<br>
<br>
This is old code: some of it goes back 15 years. Holding
on to unused, uncallable code is akin to hoarding. <br>
<br>
<br>
<blockquote type="cite"> <br>
Ade <br>
<br>
On Thu, 2011-11-10 at 22:29 -0500, Adam Young wrote: <br>
<blockquote type="cite">_______________________________________________
<br>
Pki-devel mailing list <br>
<a moz-do-not-send="true"
href="mailto:Pki-devel@redhat.com">Pki-devel@redhat.com</a>
<br>
<a moz-do-not-send="true"
href="https://www.redhat.com/mailman/listinfo/pki-devel">https://www.redhat.com/mailman/listinfo/pki-devel</a>
<br>
</blockquote>
<br>
</blockquote>
<br>
_______________________________________________ <br>
Pki-devel mailing list <br>
<a moz-do-not-send="true" href="mailto:Pki-devel@redhat.com">Pki-devel@redhat.com</a>
<br>
<a moz-do-not-send="true"
href="https://www.redhat.com/mailman/listinfo/pki-devel">https://www.redhat.com/mailman/listinfo/pki-devel</a>
<br>
</blockquote>
<br>
<br>
Conflicted with the PKI Silent changes, so patch has been
remade by hand. <br>
<br>
<br>
<br>
<pre>_______________________________________________
Pki-devel mailing list
<a moz-do-not-send="true" href="mailto:Pki-devel@redhat.com">Pki-devel@redhat.com</a>
<a moz-do-not-send="true" href="https://www.redhat.com/mailman/listinfo/pki-devel">https://www.redhat.com/mailman/listinfo/pki-devel</a>
</pre>
</blockquote>
Withdrawn., The formatting changes make it impractical to try
and reformat this. Will be resubmitted in smaller patches
shortly.<br>
<br>
<br>
<pre>_______________________________________________
Pki-devel mailing list
<a moz-do-not-send="true" href="mailto:Pki-devel@redhat.com">Pki-devel@redhat.com</a>
<a moz-do-not-send="true" href="https://www.redhat.com/mailman/listinfo/pki-devel">https://www.redhat.com/mailman/listinfo/pki-devel</a>
</pre>
</blockquote>
Rebased on top of the format changes<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Pki-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Pki-devel@redhat.com">Pki-devel@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/pki-devel">https://www.redhat.com/mailman/listinfo/pki-devel</a>
</pre>
</blockquote>
ACK - although the "reformatting" may need to be changed since this
patch was based upon having the formatting patch applied which has
since been reverted.<br>
<br>
After performing the following commands, I also was able to
successfully apply this patch using the following commands:<br>
<ul>
<li>git reset --hard HEAD~1 (from "master" --- was used to remove
a previously broken patch)<br>
</li>
<li>git branch unused_private_methods</li>
<li>git checkout unused_private_methods</li>
<li>git am --whitespace=fix --signoff <
dogtag-admiyo-0015-2-Removal-of-unused-private-methods.patch</li>
</ul>
I was able to successfully build this branch from both Eclipse and
using the "pki/scripts/compose_pki_core_packages" script.<br>
<br>
I installed the packages that I built, ran "pkicreate", configured
the CA via the Firefox browser, and successfully enrolled a
certificate.<br>
<br>
-- Matt<br>
<br>
</body>
</html>