<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 12/22/2011 04:41 PM, Adam Young wrote:
<blockquote cite="mid:4EF3A407.5090200@redhat.com" type="cite">On
12/22/2011 04:01 PM, Ade Lee wrote:
<br>
<blockquote type="cite">33 - ACK
<br>
34 - ACK
<br>
35 - ACK
<br>
36- ACK
<br>
37 - ACK
<br>
38
<br>
- In AuthAdminServlet.java , a suppress warnings annotation is
placed
<br>
before addAuthMgrPlugin(). Can it be moved closer to the code
causing
<br>
the warnings?
<br>
</blockquote>
Yep.. done
<br>
<br>
<blockquote type="cite">- Why has the return for the put() method
in SourceConfigStore and
<br>
PropConfigStore (and the corresponding interfaces been changed
from void
<br>
to string? What is supposed to be returned here?
<br>
</blockquote>
SourceConfigStore extends SimpleProperties
<br>
<br>
SimpleProperties extends Hashtable<String,String>
<br>
<br>
So it has to return a string. Config is basically properties
files: string to string.
<br>
<br>
<br>
<blockquote type="cite">
<br>
Ade
<br>
<br>
On Thu, 2011-12-22 at 15:22 -0500, Ade Lee wrote:
<br>
<blockquote type="cite">28 - ACK
<br>
29 - ACK
<br>
30 - ACK - but change the description. This has nothing to do
with
<br>
TreeSet
<br>
</blockquote>
</blockquote>
Will change it to "type safety in CMSCRLExtensions and
PublisherProcessor"
<br>
<br>
<br>
<blockquote type="cite">
<blockquote type="cite">31 - ACK
<br>
32 - For the most part - ACK. RevokedCertImpl.java looks like
it has
<br>
been reformatted though -- which is obscuring the real changes
in the
<br>
file. Please resubmit with just the relevant changes in that
file.
<br>
</blockquote>
</blockquote>
<br>
Resubmitted
<br>
<blockquote type="cite">
<blockquote type="cite">
<br>
Continuing with the rest ..
<br>
<br>
Ade
<br>
<br>
On Thu, 2011-12-22 at 13:08 -0500, Adam Young wrote:
<br>
<blockquote type="cite">These have been rebased on top of
master and might conflict with
<br>
previously submitted patches. These should all all be
relatively
<br>
independent, but it is possible that some of the later
patches require
<br>
earlier patches in order to apply. Please indicate the
patch number in
<br>
any ACK/NACK messages.
<br>
_______________________________________________
<br>
Pki-devel mailing list
<br>
<a class="moz-txt-link-abbreviated" href="mailto:Pki-devel@redhat.com">Pki-devel@redhat.com</a>
<br>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/pki-devel">https://www.redhat.com/mailman/listinfo/pki-devel</a>
<br>
</blockquote>
<br>
_______________________________________________
<br>
Pki-devel mailing list
<br>
<a class="moz-txt-link-abbreviated" href="mailto:Pki-devel@redhat.com">Pki-devel@redhat.com</a>
<br>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/pki-devel">https://www.redhat.com/mailman/listinfo/pki-devel</a>
<br>
</blockquote>
<br>
</blockquote>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Pki-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Pki-devel@redhat.com">Pki-devel@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/pki-devel">https://www.redhat.com/mailman/listinfo/pki-devel</a>
</pre>
</blockquote>
Final ACK in IRC by Ade Lee. Pushed to master<br>
</body>
</html>