<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
looks good per our discussion over irc.<br>
One little nitpick:<br>
<pre wrap="">+ * 2. Gets default.params.signingAlg from profile.
+ * If entry does not exist, selects first algorithm in allowed algorithm list that matches
How about "If entry does not exist, or contains a "-", selects first ..." ?
Conditional ACK (just fix that little comment then you are good).
thanks,
Christina
</pre>
<br>
<div class="moz-cite-prefix">On 10/30/2013 01:19 PM, Ade Lee wrote:<br>
</div>
<blockquote cite="mid:1383164357.2346.4.camel@localhost.localdomain"
type="cite">
<pre wrap="">The code to select the signing algorithm for the admin cert in a CA
install is broken. Right now, it will select SHA1 by default.
This patch fixes the broken logic and adds some additional checks.
Please review,
Ade
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Pki-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Pki-devel@redhat.com">Pki-devel@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/pki-devel">https://www.redhat.com/mailman/listinfo/pki-devel</a></pre>
</blockquote>
<br>
</body>
</html>