<html> <head> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> <div class="moz-cite-prefix"><tt>Endi,</tt><tt> </tt><tt> </tt><tt>Thanks!</tt><tt> </tt><tt> </tt><tt>On 04/17/14 09:44, Endi Sukma Dewata wrote:</tt><tt> </tt></div> <blockquote cite="mid:535004EB.6080407@redhat.com" type="cite"><tt>On 4/16/2014 9:23 PM, Matthew Harmsen wrote: </tt><tt> </tt> <blockquote type="cite"><tt>This patch addresses the following two tickets: </tt><tt> </tt> <tt> </tt><tt> * PKI TRAC Ticket #843 - Incorrect CLI argument parsing </tt><tt> </tt><tt> <a class="moz-txt-link-rfc2396E" href="https://fedorahosted.org/pki/ticket/843"><https://fedorahosted.org/pki/ticket/843></a> </tt><tt> </tt><tt> * PKI TRAC Ticket #918 - CLI commands does not return code '1' for the </tt><tt> </tt><tt> failures <a class="moz-txt-link-rfc2396E" href="https://fedorahosted.org/pki/ticket/918"><https://fedorahosted.org/pki/ticket/918></a> </tt><tt> </tt> <tt> </tt><tt>This patch was tested on a Fedora 20 machine using code from the </tt><tt> </tt><tt>'master' branch via the attached shell script called /*pkiclihelp*/. </tt><tt> </tt> <tt> </tt><tt>I would like to check this developer's tool into the 'pki/base/scripts/' </tt><tt> </tt><tt>directory for future use. </tt><tt> </tt></blockquote> <tt> </tt><tt>Yes, probably QE can use this tool as well. What is the difference between pki/scripts and pki/base/scripts? </tt><tt> </tt></blockquote> <tt> We used to have similar directories (e. g. - </tt><tt>'pki/dogtag/scripts'</tt><tt> and</tt><tt> 'pki/redhat/scripts'</tt><tt> associated with the Dogtag and Red Hat themes respectively) which housed scripts primarily used for the legacy method of building individual RPMS and SRPMS (e. g. - pki-ca RPM and pki-ca SRPM as opposed to pki-ca RPM and pki-core SRPM). This separation allowed theme packages and their icons to reside in separate repositories and still be built utilizing the same core server/client pieces, as at that time, at least one theme was required and the themes were mutually exclusive.</tt><tt> </tt><tt> </tt><tt>Since we do not really ship any devel packages, the scripts under 'pki/base/scripts' were just meant for un-packaged development tools related to the core server/client pieces - similar to the 'pki/tools' directory which was created at a later date to house development tools which were not scripts.</tt><tt> </tt><tt> </tt><tt> </tt><tt>Since Dogtag 10.x builds individual SRPMS which often contain numerous RPMS, the 'pki/scripts/' directory houses scripts used for building these and pertain to the PKI project as well as its default Dogtag theme.</tt><tt> </tt><tt> </tt><tt>For now, I will check the 'pkiclihelp' script into the 'pki/base/scripts' directory, but it may make sense to re-organize and consolidate some of these directories in the future.</tt><tt> -- Matt </tt> <blockquote cite="mid:535004EB.6080407@redhat.com" type="cite"> <blockquote type="cite"><tt>Screen output is present in the attachment called </tt><tt> </tt><tt>/*pkiclihelp_terminal_display*/. </tt><tt> </tt> <tt> </tt><tt>The log file produced is present in the attachment called </tt><tt> </tt><tt>/*pki_cli_help.log*/. </tt><tt> </tt> <tt> </tt><tt>Please review this patch. </tt><tt> </tt> <tt> </tt><tt>Thanks, </tt><tt> </tt><tt>-- Matt </tt><tt> </tt></blockquote> <tt> </tt><tt>ACK. </tt><tt> </tt> <tt> </tt> </blockquote> </body> </html>